Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: support icon and description in preset#18977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ssncferreira merged 7 commits intomainfromssncferreira/feat-preset-icon-description
Jul 28, 2025

Conversation

ssncferreira
Copy link
Contributor

@ssncferreirassncferreira commentedJul 21, 2025
edited
Loading

Description

This PR adds support fordescription andicon fields totemplate_version_presets. These fields will allow displaying richer information for presets in the UI, improving the user experience when creating a workspace.
Both fields are optional, non-nullable, and default to empty strings.

Changes

  • Database migration with the addition ofdescription VARCHAR(128) andicon VARCHAR(256) columns to thetemplate_version_presets table.
  • Updated theCreateWorkspacePageView in the UI

Note: UI changes will be addressed in a separate PR

@coderabbitaicoderabbitai
Copy link

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the.coderabbit.yaml file in this repository. To trigger a single review, invoke the@coderabbitai review command.

You can disable this status message by setting thereviews.review_status tofalse in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat withCodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag@coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag@coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on oursupport page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings togenerate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add@coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add@coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add@coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a.coderabbit.yaml file to the root of your repository.
  • Please see theconfiguration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit ourDocumentation for detailed information on how to use CodeRabbit.
  • Join ourDiscord Community to get help, request features, and share feedback.
  • Follow us onX/Twitter for updates and announcements.

@ssncferreirassncferreiraforce-pushed thessncferreira/feat-preset-icon-description branch 4 times, most recently from303e4d1 to531420fCompareJuly 24, 2025 15:06
Comment on lines +2 to +3
ADD COLUMN IF NOT EXISTS descriptionVARCHAR(128)NOT NULL DEFAULT'',
ADD COLUMN IF NOT EXISTS iconVARCHAR(256)NOT NULL DEFAULT'';
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add a comment on these fields.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Addressed in:dcc6619

@ssncferreirassncferreiraforce-pushed thessncferreira/feat-preset-icon-description branch 3 times, most recently from67bd572 to9310007CompareJuly 24, 2025 15:50
@ssncferreirassncferreiraforce-pushed thessncferreira/feat-preset-icon-description branch from9310007 to24493deCompareJuly 24, 2025 15:56
@ssncferreirassncferreira marked this pull request as ready for reviewJuly 24, 2025 16:03
Comment on lines +2 to +3
ADD COLUMN IF NOT EXISTS descriptionVARCHAR(128)NOT NULL DEFAULT'',
ADD COLUMN IF NOT EXISTS iconVARCHAR(256)NOT NULL DEFAULT'';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add a comment on these fields.

@ssncferreirassncferreira changed the titlefeat: add icon and description to presetfeat: support icon and description in presetJul 28, 2025
@ssncferreirassncferreira requested review fromjohnstcn andSasSwart and removed request forjaaydenhJuly 28, 2025 12:08
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Obligatory reminder to check migration number before merging!

ssncferreira reacted with thumbs up emoji
@ssncferreirassncferreira merged commit0672bf5 intomainJul 28, 2025
29 of 31 checks passed
@ssncferreirassncferreira deleted the ssncferreira/feat-preset-icon-description branchJuly 28, 2025 14:02
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 28, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@spikecurtisspikecurtisAwaiting requested review from spikecurtisspikecurtis is a code owner

@SasSwartSasSwartAwaiting requested review from SasSwart

Assignees

@ssncferreirassncferreira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ssncferreira@johnstcn

[8]ページ先頭

©2009-2025 Movatter.jp