- Notifications
You must be signed in to change notification settings - Fork948
feat: add View Source button for template administrators in workspace creation#18951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
blink-so wants to merge4 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+70 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
… creationAdds a View Source button to the workspace creation page that allows templateadministrators to quickly navigate to the template editor. The button:- Only appears for users with template update permissions- Links directly to the template version editor- Uses the ExternalLinkIcon for consistency with other source viewing features- Is positioned next to the Cancel button in the page headerThis addresses user friction where template admins expect to be able to edittemplates directly from the workspace creation flow.Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
This comment was marked as spam.
This comment was marked as spam.
Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
aslilac requested changesJul 21, 2025
Member
aslilac left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
needs a story added to storybook to exercise this change
Adds two new stories to test the View Source button functionality:- WithViewSourceButton: Shows the button for template administrators- WithoutViewSourceButton: Hides the button for regular usersThese stories exercise the canUpdateTemplate prop and demonstratethe conditional rendering of the View Source button.Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
Adds a "View Source" button to the workspace creation page that allows template administrators to quickly navigate to the template editor.
Context:https://codercom.slack.com/archives/C015YDF37AT/p1753109218026359
Changes
canUpdateTemplatepermission check to workspace creation flowExternalLinkIconfor consistency with other source viewing featuresProblem Solved
Addresses user friction where template administrators expect to be able to edit templates directly from the workspace creation flow. Previously, admins had to navigate away from the workspace creation page to find the template editor.
Testing
Screenshots
The View Source button appears in the top-right corner of the workspace creation page, similar to the implementation shown in the original request.
Fixes user feedback about template admin workflow friction.