Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add managed ai usage consumption to license view#18934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ibetitsmike merged 12 commits intomainfrommike/add-managed-ai-usage-to-license-view
Jul 28, 2025

Conversation

ibetitsmike
Copy link
Contributor

@ibetitsmikeibetitsmike commentedJul 21, 2025•
edited by deansheather
Loading

Customers with licenses not supporting managed AI agents will receive the following information:
image

Customers with active licenes for managed AI agents will see:
image

Closescoder/internal#813

@ibetitsmikeibetitsmikeforce-pushed themike/add-managed-ai-usage-to-license-view branch from1bb6714 tobcb7faaCompareJuly 22, 2025 13:05
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Video looks great! Deferring to a frontend person to approve, though

Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

  • The "Disabled" story shows NaN on the page which seems like a bug
  • I would expect the "near limit" bar to not be green anymore. Maybe yellow or orange instead.
  • You've got a mixture of Tailwind styles and Emotion styles in theManagedAgentsConsumption component. New use of Emotion is discouraged, please just use Tailwind (but using thestyle prop for the percentage math is correct)
  • It feels weird the have the bar "full" when it's only visually 50% filled. I wonder if the usage bar should be non-linear. For example the first 80% could always be in the range[0, softLimit] and the last 20% could be in the range[softLimit, hardLimit].

@ibetitsmikeibetitsmike added this to theCode Stability milestoneJul 28, 2025
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd still like it if over-usage was yellow but I won't block on it

@aslilacaslilacforce-pushed themike/add-managed-ai-usage-to-license-view branch fromd2a56d0 tof44e42fCompareJuly 28, 2025 17:42
@ibetitsmikeibetitsmike merged commit36d2e01 intomainJul 28, 2025
26 of 27 checks passed
@ibetitsmikeibetitsmike deleted the mike/add-managed-ai-usage-to-license-view branchJuly 28, 2025 18:27
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 28, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather left review comments

@aslilacaslilacaslilac approved these changes

Assignees

@ibetitsmikeibetitsmike

Labels
None yet
Projects
None yet
Milestone
Code Stability
Development

Successfully merging this pull request may close these issues.

Managed agent license usage frontend
3 participants
@ibetitsmike@aslilac@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp