- Notifications
You must be signed in to change notification settings - Fork1k
feat: add logo SVG and replace inline SVG with image reference#18930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat: add logo SVG and replace inline SVG with image reference#18930
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ization pageChange-Id: Iad1117eaa5b83a223bd8fbd91f006880ec9a7569Signed-off-by: Thomas Kosiewski <tk@coder.com>
fcd361d intomainUh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this file already existed at /icon/coder.svg, why didn't we use that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oops.
@Parkreiner pointed out some additional items still pending update, so maybe we can address this as part of that.
See#18878
Replace SVG with external logo file in OAuth2 authorization page
This PR replaces the inline SVG logo in the OAuth2 authorization page with a reference to an external SVG file. The change:
logo.svgfile in the static directory with the Coder logoThis approach improves maintainability by centralizing the logo in a single file and reduces duplication in the codebase.