refactor: simplify OAuth2 authorization flow and use 302 redirects#18923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open

ThomasK33 wants to merge1 commit intomain

base:main

Choose a base branch

Open

+43 −96

Conversation

Copy link

Member

This PR refactors the OAuth2 provider authorization flow by:

Removing theauthorizeMW middleware and directly implementing its functionality in theShowAuthorizePage handler
Simplifying function signatures by removing unnecessary parameters:
- Removeddb parameter fromShowAuthorizePage
- RemovedaccessURL parameter fromProcessAuthorize
Changing the redirect status code inProcessAuthorize from 307 (Temporary Redirect) to 302 (Found) to improve compatibility with external OAuth2 apps and browsers

The changes maintain the same functionality while making the code more straightforward and improving compatibility with external systems.

ThomasK33 marked this pull request as ready for review

github-actionsbot assignedThomasK33

Copy link

MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

refactor(oauth2): simplify authorization flow by removing middleware …

6f159c6

…layerChange-Id: Ieff16b08aeb2cf2357ada11d83fd408cc66c6c5aSigned-off-by: Thomas Kosiewski <tk@coder.com>

ThomasK33 force-pushed thethomask33/07-20-refactor_oauth2_simplify_authorization_flow_by_removing_middleware_layer branch fromee2ff90 to6f159c6Compare

ThomasK33 requested a review fromkylecarbs