NotificationsYou must be signed in to change notification settings
Fork948
Star10.5k

feat: add workspace_apps configuration to control apps in workspace table#18922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

blink-so wants to merge9 commits intomainfromfeat/configurable-display-app-icons

Closed

feat: add workspace_apps configuration to control apps in workspace table#18922

blink-so wants to merge9 commits intomainfromfeat/configurable-display-app-icons

Conversation

Copy link

Contributor

blink-sobot commentedJul 19, 2025

This PR adds the ability to configure which apps appear in the workspace table on the /workspaces page via terraform.

Changes

Addedworkspace_apps field to thecoder_agent terraform resource
Updated proto definitions to include workspace_apps
Modified the WorkspaceApps component to respect the configured apps list
Added support for both built-in apps (vscode, vscode_insiders, web_terminal) and custom apps

Usage Example

resource"coder_agent""main" {os="linux"arch="amd64"# Configure which apps appear in the workspace tableworkspace_apps=["vscode","my-custom-app","web_terminal"]}

Implementation Notes

Maximum of 4 apps are displayed (existing limit)
Apps are shown in the order specified in the configuration
Falls back to existing behavior if workspace_apps is not specified
Custom apps can be referenced by slug or ID

TODO

Add database migration for workspace_apps column
Update backend to populate workspace_apps from provisioner data
Add comprehensive documentation
Add tests

Requested by@jacqueline in Slack.

blink-sobot added2 commits

July 19, 2025 19:01

feat: update workspace button text to show 'Open VS Code in Browser'

550c22d

Updated the button labels on the /workspaces page to clearly indicate that VS Code opens in the browser, matching the UI mockup provided.

feat: add workspace_apps configuration to control apps shown in works…

e8de998

…pace table- Added workspace_apps field to terraform coder_agent resource- Updated proto definition to include workspace_apps- Modified frontend WorkspaceApps component to respect configured apps- Allows specifying which apps (built-in and custom) appear in the workspace table- Maximum of 4 apps displayed, in the order specified

blink-sobot requested review fromaslilac,spikecurtis andjohnstcn ascode owners

July 19, 2025 19:23

blink-sobot added3 commits

July 19, 2025 19:27

fix: regenerate proto files with workspace_apps field

c74817b

feat: add backend support for workspace_apps

7b9597b

- Add database migration for workspace_apps column- Update SQL queries to include workspace_apps- Update provisioner server to pass workspace_apps from terraform- Still needs: database code regeneration and API updates

feat: implement workspace_apps feature

eb77a5e

Add workspace_apps configuration to control which apps appear in workspace table:- Add database migration for workspace_apps column- Update WorkspaceAgent struct to include workspace_apps field- Update SQL queries to handle workspace_apps- Add comprehensive tests for the new functionality- Add documentation with examplesThis allows administrators to configure via Terraform which appsappear as action buttons in the workspace table while maintainingbackward compatibility.

blink-sobotforce-pushed thefeat/configurable-display-app-icons branch from0c281d9 toeb77a5eCompare

July 19, 2025 19:57

blink-sobot added4 commits

July 19, 2025 20:02

fix: add WorkspaceApps field to InsertWorkspaceAgentParams

f6d8727

This ensures the generated database code includes the workspace_apps fieldneeded for the feature to compile properly.

fix: correct parameter names for getVSCodeHref and getTerminalHref fu…

c39b8b2

…nctions

fix: replace any type with proper type assertion for workspace_apps

92b942c

fix: update database schema dump to include workspace_apps column

792fa68

Copy link

Member

matifali commentedJul 21, 2025

This can be controlled withorder I think.

johnstcn requested changes

Jul 21, 2025

View reviewed changes

Copy link

Member

johnstcn left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is the intention here to allow full customization of the apps shown in the workspace list as opposed to the workspace details? Having a different ordering on the list as opposed to the details page seems potentially confusing.

Instead of adding yet another field on our provider, an alternative solution could be to simply include the first fourcoder_app instances based on theorder field and what is set indisplay_apps. I'd suggestdisplay_apps taking priority and then 'filling in' the remainder with the top Ncoder_apps based onorder (up to max 4 apps).

EDIT: this appears to be the current logic. We first prioritize the 'built-in apps' and then fill in the remaining 'slots' with any healthy non-hidden user apps.