- Notifications
You must be signed in to change notification settings - Fork948
feat: improve workspace upgrade flow when template parameters change#18917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
aslilac wants to merge5 commits intomainChoose a base branch fromlilac/update-workspace-parameters
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#18259
Historically, we've had some frontend code to detect conditions which would lead to build failures, and we would require their correction before ever talking to the backend. In a dynamic parameters world there are nowmany more possible ways this could fail and validating all of that on the frontend would be a lot of duplication and have a lot of room for logic errors.
We have decided to simplify, and delegate all parameter validation to the backend. The only ways which canauthoritatively validate parameters is to actually trigger a build or establish an evaluation loop over WebSocket. As such, instead of doing any upfront validation on the frontend, we should just queue up a build and see what happens. This has two primary outcomes...
Importantly, the build will fail during a validation step that is performed on the backend. It will not actually add a job to the job queue. It does not require the availability of a provisioner. The response time was always very fast when testing locally, and shouldn't be of concern.