Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: improve workspace upgrade flow when template parameters change#18917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 5 commits intomainfromlilac/update-workspace-parameters
Jul 21, 2025

Conversation

aslilac
Copy link
Member

Closes#18259

Historically, we've had some frontend code to detect conditions which would lead to build failures, and we would require their correction before ever talking to the backend. In a dynamic parameters world there are nowmany more possible ways this could fail and validating all of that on the frontend would be a lot of duplication and have a lot of room for logic errors.

We have decided to simplify, and delegate all parameter validation to the backend. The only ways which canauthoritatively validate parameters is to actually trigger a build or establish an evaluation loop over WebSocket. As such, instead of doing any upfront validation on the frontend, we should just queue up a build and see what happens. This has two primary outcomes...

  1. The build is fine, which means we would've queued it up anyway after validation (if we were doing any frontend pre-validation)
  2. The build fails and we get back validation errors. We detect this and redirect to the parameters settings page, where an evaluation WebSocket will be established and the user can update things as necessary. When they are done, they'll queue another build from here which should succeed.

Importantly, the build will fail during a validation step that is performed on the backend. It will not actually add a job to the job queue. It does not require the availability of a provisioner. The response time was always very fast when testing locally, and shouldn't be of concern.

@aslilacaslilac requested review fromEmyrk andjaaydenhJuly 18, 2025 00:25
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@aslilacaslilac merged commit19afeda intomainJul 21, 2025
24 of 26 checks passed
@aslilacaslilac deleted the lilac/update-workspace-parameters branchJuly 21, 2025 21:42
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

@jaaydenhjaaydenhAwaiting requested review from jaaydenh

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prompt missing params does not capture all validation criteria
2 participants
@aslilac@Emyrk

[8]ページ先頭

©2009-2025 Movatter.jp