Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(agent/agentcontainers): fixTestAPI/NoUpdaterLoopLogspam flake#18905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DanielleMaywood merged 4 commits intomainfromdanielle/fix-agentcontainers-flake
Jul 17, 2025

Conversation

DanielleMaywood
Copy link
Contributor

@DanielleMaywoodDanielleMaywood commentedJul 16, 2025•
edited
Loading

Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR fixes a flake inTestAPI/NoUpdaterLoopLogspam by ensuring the watcher loop’s initialization log does not race with test assertions.

  • Injects afakeWatcher into the API viaWithWatcher to control watcher behavior during tests
  • Usestestutil.RequireReceive to wait for the watcher loop to start before advancing the clock
Comments suppressed due to low confidence (1)

agent/agentcontainers/api_test.go:361

  • [nitpick] The variable namefWatcher is a bit ambiguous. Consider renaming it towatcher orfakeWatcher for improved readability in tests.
fWatcher = newFakeWatcher(t)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@DanielleMaywoodDanielleMaywood merged commitfb00cd2 intomainJul 17, 2025
30 checks passed
@DanielleMaywoodDanielleMaywood deleted the danielle/fix-agentcontainers-flake branchJuly 17, 2025 09:59
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 17, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

Copilot code reviewCopilotCopilot left review comments

@dannykoppingdannykoppingdannykopping approved these changes

Assignees

@DanielleMaywoodDanielleMaywood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake:TestAPI/NoUpdaterLoopLogspam
2 participants
@DanielleMaywood@dannykopping
[8]ページ先頭
©2009-2025 Movatter.jp