- Notifications
You must be signed in to change notification settings - Fork948
feat: add customizable signups disabled text for all authentication methods#18887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
blink-so wants to merge10 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ethodsThis change adds a general --signups-disabled-text configuration optionthat allows administrators to customize the message shown when signupsare disabled, regardless of the authentication method used.Changes:- Add SignupsDisabledText field to DeploymentValues struct- Add --signups-disabled-text CLI flag and CODER_SIGNUPS_DISABLED_TEXT env var- Update userauth logic to use general text with OIDC fallback for backward compatibility- Add new User Authentication deployment group for general auth settings- Support Markdown formatting in the custom textThis enhances the existing OIDC-specific signups disabled text to workwith all authentication methods, providing better flexibility foradministrators to inform users about signup policies.Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
- Update CLI documentation with new --signups-disabled-text flag- Add USER AUTHENTICATION section to enterprise help golden file- Update TypeScript types with signups_disabled_text fieldCo-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Remove extra blank lines and ensure files end with exactly one newlineCo-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Add blank lines after titles and before sections to match linter expectationsCo-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Add missing blank lines after '## Usage' sections in CLI documentationfiles to match the expected formatting from make gen.Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Run CLI documentation generation using the project's clidocgen toolto ensure proper formatting and structure that matches CI expectations.Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Run clidocgen followed by markdownlint-cli2 and markdown-table-formatterto match the exact formatting that CI expects.Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Format docs/manifest.json with biome and include the generateddocumentation for the new --signups-disabled-text CLI flag.Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a general
--signups-disabled-textconfiguration option that allows administrators to customize the message shown when signups are disabled, regardless of the authentication method used.Changes
DeploymentValuesstruct with CLI flag--signups-disabled-textand environment variableCODER_SIGNUPS_DISABLED_TEXTBenefits
Usage
The general setting takes precedence over the OIDC-specific setting, ensuring consistent messaging across all authentication methods while maintaining backward compatibility.
Tested: Code compiles successfully and maintains existing functionality.