- Notifications
You must be signed in to change notification settings - Fork948
chore: add kiro: protocol to external app whitelist#18884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Adds 'kiro:' to ALLOWED_EXTERNAL_APP_PROTOCOLS to enable session tokeninjection for kiro.dev URIs when opened from the workspace page.This allows kiro.dev applications to receive the user's session tokenfor authentication when launched via kiro:// protocol links.Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
matifali approved these changesJul 15, 2025
/cherry-pick release/2.24 |
e76115c intomain 33 of 35 checks passed
Uh oh!
There was an error while loading.Please reload this page.
gcp-cherry-pick-botbot pushed a commit that referenced this pull requestJul 15, 2025
Co-authored-by: blink-so[bot] <211532188+blink-so[bot]@users.noreply.github.com>Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
kiro:to theALLOWED_EXTERNAL_APP_PROTOCOLSwhitelist to enable session token injection for kiro.dev URIs when opened from the workspace page.Changes
"kiro:"to theALLOWED_EXTERNAL_APP_PROTOCOLSarray insite/src/modules/apps/apps.tsWhy
This change allows kiro.dev applications to receive the user's session token for authentication when launched via
kiro://protocol links from the Coder workspace page, following the same pattern as other supported IDE protocols likevscode:,cursor:,windsurf:, andjetbrains:.Testing
This is a simple whitelist addition that follows the existing pattern. The change enables:
kiro://URIs containing$SESSION_TOKENplaceholderSecurity
The whitelist approach ensures that only approved protocols can receive session tokens, maintaining security while enabling kiro.dev integration.