- Notifications
You must be signed in to change notification settings - Fork1k
fix: allow non-HTTP URIs in OAuth2 provider redirect URIs#18880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
ThomasK33 wants to merge1 commit intothomask33/07-14-feat_oauth2_add_bulk_token_revocation_endpoint_with_usage_trackingChoose a base branch
base:thomask33/07-14-feat_oauth2_add_bulk_token_revocation_endpoint_with_usage_tracking
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedJul 15, 2025
MemberAuthor
ThomasK33 commentedJul 15, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stackon Graphite.
This stack of pull requests is managed byGraphite. Learn more aboutstacking. |
80b2b40 toa29e00aCompare4e82d80 to8830706Comparea29e00a to63934b4Compare8830706 to13de8e2Compared9ecda1 to0b47133Compare13de8e2 tob4a9dbdCompare0b47133 to99e7a7bCompare… for native appsChange-Id: I4000cd39caa994efe0b76c4984e968f2963063caSigned-off-by: Thomas Kosiewski <tk@coder.com>
99e7a7b toc2346ffCompareb4a9dbd to72cf224CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed OAuth2 redirect URI validation to accept custom URI schemes
This PR updates the validation for OAuth2 provider app redirect URIs to use the more flexible
urivalidator instead of the stricterhttp_urlvalidator. This allows for custom URI schemes that don't follow reverse domain notation, while still blocking well-known schemes like http, https, ftp, etc.The change removes the requirement that custom schemes must contain a period, making the validation more permissive for various client applications while maintaining security by continuing to block well-known schemes.