- Notifications
You must be signed in to change notification settings - Fork948
feat: sign coder binaries with the release key using GPG (cherry-pick #18774)#18869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
gcp-cherry-pick-bot wants to merge1 commit intorelease/2.23Choose a base branch
base:release/2.23
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
### DescriptionThis PR introduces GPG signing for all Coder *slim-binaries*.Detached signatures will allow users to verify the integrity andauthenticity of the binaries they download.### Changes * `scripts/sign_with_gpg.sh`: New script to sign a given binary using GPG. It imports the release key, signs the binary, and verifies the signature. * `scripts/build_go.sh`: Updated to call `sign_with_gpg.sh` when the `CODER_SIGN_GPG` environment variable is set to 1. * `.github/workflows/release.yaml`: The` CODER_SIGN_GPG` environment variable is now set to 1 during the release build, enabling GPG signing for all release binaries. * `.github/workflows/ci.yaml`: The `CODER_SIGN_GPG` environment variable is now set to 1 during the CI build, enabling GPG signing for all CI binaries.* `Makefile`: Detached signatures are moved to the `/site/out/bin/`directory
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked feat: sign coder binaries with the release key using GPG (#18774)
Description
This PR introduces GPG signing for all Coderslim-binaries.
Detached signatures will allow users to verify the integrity and
authenticity of the binaries they download.
Changes
scripts/sign_with_gpg.sh: New script to sign a given binaryusing GPG. It imports the release key, signs the binary, and
verifies the signature.
scripts/build_go.sh: Updated to callsign_with_gpg.shwhen theCODER_SIGN_GPGenvironment variable is set to 1..github/workflows/release.yaml: TheCODER_SIGN_GPGenvironmentvariable is now set to 1 during the release build, enabling GPG
signing for all release binaries.
.github/workflows/ci.yaml: TheCODER_SIGN_GPGenvironmentvariable is now set to 1 during the CI build, enabling GPG
signing for all CI binaries.
Makefile: Detached signatures are moved to the/site/out/bin/directory