Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(agent/agentcontainers): fixTestAPI/IgnoreCustomization flake#18863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DanielleMaywood merged 3 commits intomainfromdanielle/devcontainer-test-flake
Jul 15, 2025

Conversation

DanielleMaywood
Copy link
Contributor

@DanielleMaywoodDanielleMaywood commentedJul 14, 2025•
edited
Loading

Fixes a flake spotted herehttps://github.com/coder/coder/actions/runs/16277283041/job/45959150449

The flake occurred due to a race condition betweenRefreshContainers and the file system watcher. We might want to improve how these tests are written in the future, but for now it appears this change has fixed the flake on my Coder Workspace.

How I ran the test to recreate the issue

seq 1 128| xargs -P 64 -I {} sh -c'echo "Run {}:" &&  go test -run="TestAPI/IgnoreCustomization" -race -count=20 ./agent/agentcontainers'

@DanielleMaywoodDanielleMaywood changed the titlefix(agent/agentcontainers): resolve flakefix(agent/agentcontainers): fixTestAPI/IgnoreCustomization flakeJul 14, 2025
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

Fixes a flaky race condition in TestAPI by waiting for container refresh to complete before asserting subagent creation.

  • Wrappedapi.RefreshContainers calls inrequire.Eventuallyf to poll forfakeSAC.created entries after filesystem events.
  • Applied the same change in both phases of the test to ensure subagent creation is detected reliably.

@DanielleMaywoodDanielleMaywood marked this pull request as ready for reviewJuly 14, 2025 22:35
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@DanielleMaywoodDanielleMaywood merged commitbd3d0ea intomainJul 15, 2025
32 checks passed
@DanielleMaywoodDanielleMaywood deleted the danielle/devcontainer-test-flake branchJuly 15, 2025 09:01
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

Copilot code reviewCopilotCopilot left review comments

@mtojekmtojekmtojek approved these changes

Assignees

@DanielleMaywoodDanielleMaywood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@DanielleMaywood@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp