- Notifications
You must be signed in to change notification settings - Fork1k
fix: exclude prebuilt workspaces from lifecycle executor (cherry-pick #18762)#18858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
## DescriptionThis PR updates the lifecycle executor to explicitly exclude prebuiltworkspaces from being considered for lifecycle operations such as`autostart`, `autostop`, `dormancy`, `default TTL` and `failure TTL`.Prebuilt workspaces (i.e., those owned by the prebuild system user) arehandled separately by the prebuild reconciliation loop. Including themin the lifecycle executor could lead to unintended behavior such asincorrect scheduling or state transitions.## Changes* Updated the lifecycle executor query`GetWorkspacesEligibleForTransition` to exclude workspaces with`owner_id = 'c42fdf75-3097-471c-8c33-fb52454d81c0'` (prebuilds).* Added tests to verify prebuilt workspaces are not considered in: * Autostop * Autostart * Default TTL * Dormancy * Failure TTLFixes:#18740Related to:#18658
matifali approved these changesJul 15, 2025
51e60b7 intorelease/2.24 31 of 33 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: exclude prebuilt workspaces from lifecycle executor (#18762)
Description
This PR updates the lifecycle executor to explicitly exclude prebuilt
workspaces from being considered for lifecycle operations such as
autostart,autostop,dormancy,default TTLandfailure TTL.Prebuilt workspaces (i.e., those owned by the prebuild system user) are
handled separately by the prebuild reconciliation loop. Including them
in the lifecycle executor could lead to unintended behavior such as
incorrect scheduling or state transitions.
Changes
GetWorkspacesEligibleForTransitionto exclude workspaces withowner_id = 'c42fdf75-3097-471c-8c33-fb52454d81c0'(prebuilds).Fixes:#18740
Related to:#18658