NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

example: added hetzner cloud workspace#1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

ntimo wants to merge4 commits intocoder:mainfromntimo:task/hetzner-cloud-workspace-template

Closed

example: added hetzner cloud workspace#1884

ntimo wants to merge4 commits intocoder:mainfromntimo:task/hetzner-cloud-workspace-template

Conversation

Copy link

Contributor

ntimo commentedMay 29, 2022•
edited
Loading

This PR adds an example forHetzner Cloud.
The general idea is to let the user create a cloud instance and mount a persistent volume to it. And when the workspace is stopped to unmount the volume and delete the instance to save costs (only the volume will be paid during the stopped time).

In summary this template does:

Creates a Hetzner Cloud instance
Create a Hetzner Cloud volume
Create a default block inbound firewall policy
Add volumes and firewall policy to the instance
Ask the user if code-server should be installed and if so installs it

Note: I had to create a new PR because the fork relation of my fork from#1044 broke.

Copy link

ContributorAuthor

ntimo commentedMay 29, 2022

Note: For some reasoncoder ssh <name>.dev does not work with version 0.6.0 of coder with this template yet.

Copy link

Member

bpmct commentedMay 29, 2022

Note: For some reasoncoder ssh <name>.dev does not work with version 0.6.0 of coder with this template yet.

@kylecarbs any idea why the agent is showing up for the non-server resources?

┌─────────────────────────────────────────────────────────────────────────────────────────┐│ RESOURCE                                   STATUS              ACCESS                   │├─────────────────────────────────────────────────────────────────────────────────────────┤│ hcloud_firewall.root                       ephemeral                                    │├─────────────────────────────────────────────────────────────────────────────────────────┤│ hcloud_firewall_attachment.root_fw_attach  ephemeral                                    ││ └─ dev (linux, amd64)                      ⦾ connecting [15s]   coder ssh hetztest.dev  │├─────────────────────────────────────────────────────────────────────────────────────────┤│ hcloud_server.root                         ephemeral                                    ││ └─ dev (linux, amd64)                      ⦾ connecting [15s]   coder ssh hetztest.dev  │├─────────────────────────────────────────────────────────────────────────────────────────┤│ hcloud_volume.root                         ephemeral                                    │├─────────────────────────────────────────────────────────────────────────────────────────┤│ hcloud_volume_attachment.root              ephemeral                                    ││ └─ dev (linux, amd64)                      ⦿ connected          coder ssh hetztest.dev  │└─────────────────────────────────────────────────────────────────────────────────────────┘

Copy link

Member

kylecarbs commentedMay 29, 2022•
edited
Loading

Hmm, I'll check this out. I think the DAG needs adjustment to use the closest node, and not work its way entirely up the tree.

mafredri reviewed

May 30, 2022

View reviewed changes

Copy link

Member

mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work, thanks for your contribution@ntimo!

examples/hetzner-linux/main.tf OutdatedShow resolvedHide resolved

examples/hetzner-linux/main.tfShow resolvedHide resolved

mafredri mentioned this pull request

May 30, 2022

Multiple terraform resources are detected as multiple workspaces, resulting in inability to SSH and unrecognized name#1750

Closed

ntimo force-pushed thetask/hetzner-cloud-workspace-template branch from6a2c192 to49ff3a3Compare

May 30, 2022 15:14

example: added hetzner cloud workspace

be89a0e

ntimo force-pushed thetask/hetzner-cloud-workspace-template branch from49ff3a3 tobe89a0eCompare

May 30, 2022 16:23

ntimo requested a review frommafredri

May 30, 2022 16:31

tjcran added nice-to-have and removed nice-to-have labels

May 30, 2022

bpmct mentioned this pull request

Jun 8, 2022

fix: Improve Terraform agent<->resource association testing#2187

Merged

Copy link

ContributorAuthor

ntimo commentedJun 9, 2022

I just tested this again with coder version 0.6.5 and coder detects the wrong terraform resource as the server (the firewall attachment resource is detected)@kylecarbs @bpmct

Copy link

Member

kylecarbs commentedJun 9, 2022

@ntimo this is certainly a bug on our end. I'll pull the template and try it out.

Copy link

Member

kylecarbs commentedJun 9, 2022

@ntimo found the bug! Pushing a fix in ~1hr

Copy link

ContributorAuthor

ntimo commentedJun 9, 2022

Thanks@kylecarbs you are awesome

example: added Code-Server installation to hetzner template

dd57b0e

ntimo force-pushed thetask/hetzner-cloud-workspace-template branch frombf9af6e todd57b0eCompare

June 9, 2022 19:31

Copy link

ContributorAuthor

ntimo commentedJun 9, 2022

I just added the option to chose if code-server should be installed or not when creating the workspace. This is done by using if statements inside of the cloud init file and a counter to add the coder_app resource if needed.

example: remove fedora from hetzner cloud template

87a4e48

Copy link

ContributorAuthor

ntimo commentedJun 9, 2022

I will still need to "workarround" a "issue" where hetzner is going to send the admin an email for every server that gets created. Because the server has no ssh key.

kylecarbs added a commit that referenced this pull request

Jun 9, 2022

fix: Use explicit resource order when assocating agents

43edfc4

This cleans up agent association code to explicitly map a singleagent to a single resource. This willfix#1884, and unblocka prospect from beginning a POC.

example: generate dummy ssh private key for hetzner cloud

db360b6

ntimo force-pushed thetask/hetzner-cloud-workspace-template branch from714bb9c todb360b6Compare

June 9, 2022 21:26

kylecarbs mentioned this pull request

Jun 9, 2022

fix: Use explicit resource order when assocating agents#2219

Merged

kylecarbs added a commit that referenced this pull request

Jun 9, 2022

fix: Use explicit resource order when assocating agents

d94e224

This cleans up agent association code to explicitly map a singleagent to a single resource. This willfix#1884, and unblocka prospect from beginning a POC.

kylecarbs added a commit that referenced this pull request

Jun 9, 2022

fix: Use explicit resource order when assocating agents

1033852

This cleans up agent association code to explicitly map a singleagent to a single resource. This willfix#1884, and unblocka prospect from beginning a POC.

kylecarbs added a commit that referenced this pull request

Jun 9, 2022

fix: Use explicit resource order when assocating agents

456270c

This cleans up agent association code to explicitly map a singleagent to a single resource. This willfix#1884, and unblocka prospect from beginning a POC.

kylecarbs added a commit that referenced this pull request

Jun 9, 2022

fix: Use explicit resource order when assocating agents

6f4047f

This cleans up agent association code to explicitly map a singleagent to a single resource. This willfix#1884, and unblocka prospect from beginning a POC.

kylecarbs closed this in #2219

Jun 10, 2022

kylecarbs added a commit that referenced this pull request

Jun 10, 2022

fix: Use explicit resource order when assocating agents (#2219)

f9290b0

This cleans up agent association code to explicitly map a singleagent to a single resource. This willfix#1884, and unblocka prospect from beginning a POC.

Copy link

Member

mafredri commentedJun 10, 2022

I think this one got closed by accident, reopening.

mafredri reopened this

Jun 10, 2022

Copy link

Member

kylecarbs commentedJun 10, 2022

Oh, it certainly was! It was deleted by linking it to the commit 😅.

Thanks@mafredri!

@ntimo try now, it shouldjust work!

kylecarbs added a commit that referenced this pull request

Jun 10, 2022

fix: Use explicit resource order when assocating agents (#2219)

118cc4c

This cleans up agent association code to explicitly map a singleagent to a single resource. This willfix#1884, and unblocka prospect from beginning a POC.

Copy link

ContributorAuthor

ntimo commentedJun 13, 2022

@kylecarbs looks good thank you :)

Copy link

ContributorAuthor

ntimo commentedJun 14, 2022

I guess this is ready for merge@mafredri :) What do you think?

Copy link

Member

mafredri commentedJun 16, 2022

Great work on this template@ntimo, love that you even included code-server! We've decided to showcase community templates by linking to them in the examples readme. Would you mind turning this PR into a personal repo that we can link to?

I'll make a PR today for adding a community templates section.