Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: replace original GetPrebuiltWorkspaces with optimized version#18832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 3 commits intomainfromcj/database/GetPrebuiltWorkspaces-3
Jul 21, 2025

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedJul 10, 2025•
edited
Loading

Fixescoder/internal#715

Follow-up from#18717

Once we've determined the updated query is safe, remove the duplication.

@johnstcnjohnstcn self-assigned thisJul 10, 2025
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelJul 19, 2025
@johnstcnjohnstcn removed the staleThis issue is like stale bread. labelJul 20, 2025
@johnstcnjohnstcn marked this pull request as ready for reviewJuly 20, 2025 14:39
@johnstcn
Copy link
MemberAuthor

johnstcn commentedJul 20, 2025•
edited
Loading

  • Checked Grafana and noted no log entries highlighting differences in old vs new query.
  • Inspected both old and new queries in Google Cloud and noted same avg number of rows returned for both.

Copy link
Contributor

@ssncferreirassncferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 💪
Just curious, have you observed a similar order of magnitude in performance improvement on dogfood as the one described in the previous PR?
#18717

Explain before (71.1ms):https://explain.dalibo.com/plan/9be18ab833b7a000
Explain after (9.8ms):https://explain.dalibo.com/plan/b4a94742gaha229g (EDIT: not selecting from correct CTE)
Explain after (11.2ms):https://explain.dalibo.com/plan/bea42b563ff7fbe7

@johnstcn
Copy link
MemberAuthor

LGTM 💪 Just curious, have you observed a similar order of magnitude in performance improvement on dogfood as the one described in the previous PR?#18717

It's not as good, but still significant.

Old (7d):
Screenshot 2025-07-21 at 12 15 26

New (7d):
Screenshot 2025-07-21 at 12 15 31

ssncferreira reacted with heart emoji

@johnstcnjohnstcn merged commit198d50d intomainJul 21, 2025
29 checks passed
@johnstcnjohnstcn deleted the cj/database/GetPrebuiltWorkspaces-3 branchJuly 21, 2025 14:31
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ssncferreirassncferreirassncferreira approved these changes

@SasSwartSasSwartSasSwart approved these changes

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: GetRunningPrebuiltWorkspaces creates lots of DB load
3 participants
@johnstcn@ssncferreira@SasSwart
[8]ページ先頭
©2009-2025 Movatter.jp