- Notifications
You must be signed in to change notification settings - Fork1k
fix(site): exclude workspace schedule settings for prebuilt workspaces#18826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes from2 commits
95ca5f7
207c80f
450b3e1
0bde254
73f5476
f306854
d5e45bb
0120c5b
ad475cf
02c0ff5
1260e49
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -2231,6 +2231,12 @@ func convertWorkspace( | ||
if latestAppStatus.ID == uuid.Nil { | ||
appStatus = nil | ||
} | ||
isPrebuild := false | ||
| ||
if workspace.OwnerID == database.PrebuildsSystemUserID { | ||
isPrebuild = true | ||
} | ||
return codersdk.Workspace{ | ||
ID: workspace.ID, | ||
CreatedAt: workspace.CreatedAt, | ||
@@ -2265,6 +2271,7 @@ func convertWorkspace( | ||
AllowRenames: allowRenames, | ||
Favorite: requesterFavorite, | ||
NextStartAt: nextStartAt, | ||
IsPrebuild: isPrebuild, | ||
}, nil | ||
} | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -66,6 +66,7 @@ type Workspace struct { | ||
AllowRenames bool `json:"allow_renames"` | ||
Favorite bool `json:"favorite"` | ||
NextStartAt *time.Time `json:"next_start_at" format:"date-time"` | ||
IsPrebuild bool `json:"is_prebuild"` | ||
ssncferreira marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
} | ||
func (w Workspace) FullName() string { | ||
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I'd suggest adding a story here to showcase the new behaviour. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Good catch! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Addressed in73f5476 |
Uh oh!
There was an error while loading.Please reload this page.