Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: add dev containers and scheduling to prebuilt workspaces known issues#18816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SasSwart merged 8 commits intomainfrom18806-prebuilds-known-limits
Aug 22, 2025

Conversation

EdwardAngert
Copy link
Contributor

@EdwardAngertEdwardAngert commentedJul 9, 2025
edited by coderabbitaibot
Loading

closes#18806

  • scheduling limitation
  • dev containers limitation
  • edit intro

preview

Summary by CodeRabbit

  • Documentation
    • Clarified the introduction and administrator responsibilities for prebuilt workspaces.
    • Integrated compatibility information about DevContainers and workspace scheduling more contextually.
    • Added explicit notes on limitations with dev containers integration and workspace autostart/autostop features.
    • Improved configuration examples and clarified scheduling instructions.
    • Enhanced explanations of scheduling behavior and lifecycle steps for better understanding.

@EdwardAngertEdwardAngert self-assigned thisJul 9, 2025
@EdwardAngertEdwardAngert added the docsArea: coder.com/docs labelJul 9, 2025
@matifalimatifali removed their request for reviewJuly 9, 2025 18:44
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelJul 17, 2025
@EdwardAngertEdwardAngert removed the staleThis issue is like stale bread. labelJul 17, 2025
@SasSwartSasSwart self-requested a reviewJuly 21, 2025 09:33
Copy link
Contributor

@ssncferreirassncferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for working on this 📝
Some comments regarding the workspace scheduling for prebuilds.

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelJul 29, 2025
@coderabbitaicoderabbitai
Copy link

coderabbitaibot commentedJul 29, 2025
edited
Loading

Walkthrough

The documentation for prebuilt workspaces was updated to clarify compatibility limitations, particularly with DevContainers and workspace autostart/autostop features. The changes reorganize these warnings, improve explanations of scheduling and TTL configuration, and enhance the clarity and consistency of the documentation.

Changes

Cohort / File(s)Change Summary
Prebuilt Workspaces Documentation
docs/admin/templates/extending-templates/prebuilt-workspaces.md
Revised to clarify limitations with DevContainers and workspace scheduling, improved configuration examples, reorganized warnings, and enhanced lifecycle explanations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~6 minutes

Assessment against linked issues

ObjectiveAddressedExplanation
Add disclaimer on known limitations: incompatibility with autostop (zombie workspaces) and dev containers (#18806)

Poem

In burrows deep, a doc was spun,
With warnings clear for everyone—
Prebuilds hop fast, but mind the gap,
DevContainers and autostop? Best to nap!
Schedules set with care anew,
The rabbit cheers, “These docs will do!” 🐇✨

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch18806-prebuilds-known-limits

🪧 Tips

Chat

There are 3 ways to chat withCodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag@coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag@coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on oursupport page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings togenerate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add@coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add@coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add@coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a.coderabbit.yaml file to the root of your repository.
  • Please see theconfiguration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit ourDocumentation for detailed information on how to use CodeRabbit.
  • Join ourDiscord Community to get help, request features, and share feedback.
  • Follow us onX/Twitter for updates and announcements.

Copy link

@coderabbitaicoderabbitaibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Actionable comments posted: 0

♻️ Duplicate comments (2)
docs/admin/templates/extending-templates/prebuilt-workspaces.md (2)

304-309:Duplication with earlier notice

This “Dev containers” limitation repeats the warning already given in lines 17-19. Consolidating the information in one place would keep the doc shorter and reduce maintenance overhead.


310-319:Still duplicated & previously flagged

The autostart/autostop limitation is explained in both the introduction and here. Past reviews suggested dropping the duplicate; consider removing one to avoid drift.

🧹 Nitpick comments (1)
docs/admin/templates/extending-templates/prebuilt-workspaces.md (1)

17-19:Drop “Currently” & tighten wording to avoid implying future support

Past discussion concluded that prebuilds will likely never support autostart/autostop, so “Currently” is misleading here. A leaner sentence also scans better:

-Currently, Prebuilt workspaces are not fully compatible with the-[dev containers integration](../extending-templates/devcontainers.md) or with [workspace scheduling features](../../../user-guides/workspace-scheduling.md) like autostart and autostop.+Prebuilt workspaces are not compatible with the+[dev containers integration](../extending-templates/devcontainers.md) or with [workspace scheduling features](../../../user-guides/workspace-scheduling.md) such as autostart and autostop.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between5a8a19b and1b0f88c.

📒 Files selected for processing (1)
  • docs/admin/templates/extending-templates/prebuilt-workspaces.md (6 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{go,sql,ts,tsx,js,jsx,md}

📄 CodeRabbit Inference Engine (CLAUDE.md)

Ensure files end with a newline to avoid missing newlines.

Files:

  • docs/admin/templates/extending-templates/prebuilt-workspaces.md
🔇 Additional comments (5)
docs/admin/templates/extending-templates/prebuilt-workspaces.md (5)

3-8: No actionable feedback for this introductory wording – reads clearly.


51-51: No issues – the inline clarification of86400 is helpful.


122-125:Good call-out to prefer prebuild-specific scheduling

The important note cleanly steers admins away from regular workspace scheduling.


161-165: Nothing to flag – option list is concise and accurate.


168-172: Scheduling flow description looks correct and the numbering trick renders fine.

@EdwardAngertEdwardAngert removed the staleThis issue is like stale bread. labelJul 29, 2025
@SasSwartSasSwart self-assigned thisAug 4, 2025
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelAug 12, 2025
@matifalimatifali removed the staleThis issue is like stale bread. labelAug 12, 2025
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelAug 20, 2025
SasSwartand others added2 commitsAugust 22, 2025 14:59
Co-authored-by: Susana Ferreira <susana@coder.com>
Co-authored-by: Susana Ferreira <susana@coder.com>
@SasSwartSasSwart removed the staleThis issue is like stale bread. labelAug 22, 2025
Copy link
Contributor

@ssncferreirassncferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 🍪

@SasSwartSasSwart merged commit49f32d1 intomainAug 22, 2025
29 checks passed
@SasSwartSasSwart deleted the 18806-prebuilds-known-limits branchAugust 22, 2025 13:54
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 22, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@SasSwartSasSwartSasSwart left review comments

@ssncferreirassncferreirassncferreira approved these changes

+1 more reviewer

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@SasSwartSasSwart

Labels
docsArea: coder.com/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: add known limitations to prebuilds
4 participants
@EdwardAngert@ssncferreira@SasSwart@matifali

[8]ページ先頭

©2009-2025 Movatter.jp