- Notifications
You must be signed in to change notification settings - Fork948
chore: remove dbmem#18803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
chore: remove dbmem#18803
Uh oh!
There was an error while loading.Please reload this page.
Conversation
5fe4e4f toc78f161CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🚫[linkspector]reported byreviewdog 🐶
Cannot reach ../admin/infrastructure/validated-architectures/index.md#general-concepts Status: 404 Cannot find: ../admin/infrastructure/validated-architectures/index.md#general-concepts
| *[General Concepts](../admin/infrastructure/validated-architectures/index.md#general-concepts): Essential concepts and language used to describe how Coder is structured and operated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🚫[linkspector]reported byreviewdog 🐶
Cannot reach ../admin/infrastructure/architecture.md Status: 404 Cannot find: ../admin/infrastructure/architecture.md
| *[Architecture](../admin/infrastructure/architecture.md): A high-level overview of the infrastructure layout, key services, and how components interact. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🚫[linkspector]reported byreviewdog 🐶
Cannot reachhttps://github.com/coder/coder/tree/docs-backend-contrib-guide/cli/cliui Status: 404
| *[cli](https://github.com/coder/coder/tree/main/cli): CLI interface for`coder` command built on[coder/serpent](https://github.com/coder/serpent). Input controls are defined in[cliui](https://github.com/coder/coder/tree/docs-backend-contrib-guide/cli/cliui), and[testdata](https://github.com/coder/coder/tree/docs-backend-contrib-guide/cli/testdata) contains golden files for common CLI calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🚫[linkspector]reported byreviewdog 🐶
Cannot reachhttps://github.com/coder/coder/tree/docs-backend-contrib-guide/cli/testdata Status: 404
| *[cli](https://github.com/coder/coder/tree/main/cli): CLI interface for`coder` command built on[coder/serpent](https://github.com/coder/serpent). Input controls are defined in[cliui](https://github.com/coder/coder/tree/docs-backend-contrib-guide/cli/cliui), and[testdata](https://github.com/coder/coder/tree/docs-backend-contrib-guide/cli/testdata) contains golden files for common CLI calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🚫[linkspector]reported byreviewdog 🐶
Cannot reachhttps://github.com/coder/coder/blob/docs-backend-contrib-guide/coderd/database/queries.sql.go Status: 404
| *[queries](https://github.com/coder/coder/tree/main/coderd/database/queries): contains SQL files with queries,`sqlc` compiles them to[Go functions](https://github.com/coder/coder/blob/docs-backend-contrib-guide/coderd/database/queries.sql.go) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🚫[linkspector]reported byreviewdog 🐶
Cannot reach ../../coderd/database/migrations/testdata/fixtures Status: 404 Cannot find: ../../coderd/database/migrations/testdata/fixtures
coder/docs/about/contributing/backend.md
Line 171 inc78f161
| [`migrations/testdata/fixtures`](../../coderd/database/migrations/testdata/fixtures) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🚫[linkspector]reported byreviewdog 🐶
Cannot reach ../../coderd/database/migrations/testdata/full_dumps Status: 404 Cannot find: ../../coderd/database/migrations/testdata/full_dumps
coder/docs/about/contributing/backend.md
Line 173 inc78f161
| [`migrations/testdata/full_dumps`](../../coderd/database/migrations/testdata/full_dumps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🚫[linkspector]reported byreviewdog 🐶
Cannot reach ../../coderd/database/migrations/testdata/fixtures/000024_example.up.sql Status: 404 Cannot find: ../../coderd/database/migrations/testdata/fixtures/000024_example.up.sql
coder/docs/about/contributing/backend.md
Line 196 inc78f161
| [`000024_example.up.sql`](../../coderd/database/migrations/testdata/fixtures/000024_example.up.sql) |
c78f161 to1699c6dComparehugodutka commentedJul 8, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
As far as I can tell, neither the changes in UI tests nor the linkspector errors are related to this PR. UI changes stem from some storybook views containing random strings that may change between CI runs, and the links are broken on main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🙏
It appears remaining tests depending on having dbmem have been addressed in#18797
I don't see any issues here, but deferring to Dean for approval.
@johnstcn there were more PRs actually:#15109 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🫰
1699c6d tob14e99cCompare3c2f3d6 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Remove the in-memory database. Addresses#15109.