- Notifications
You must be signed in to change notification settings - Fork947
chore: stop running postgres-only tests if DB is not set#18784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -81,7 +81,7 @@ func initDefaultConnection(t TBSubset) error { | ||
} | ||
var dbErr error | ||
// Retry up to10 seconds for temporary errors. | ||
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second) | ||
defer cancel() | ||
for r := retry.New(10*time.Millisecond, 500*time.Millisecond); r.Wait(ctx); { | ||
@@ -93,7 +93,7 @@ func initDefaultConnection(t TBSubset) error { | ||
if !containsAnySubstring(errString, retryableErrSubstrings) { | ||
break | ||
} | ||
t.Logf("%sfailed to connect to postgres, retrying: %s", time.Now().Format(time.StampMilli), errString) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. added this because it looks like we only retried 3 times, even though we're supposed to wait 10 seconds. Timestamp information will be helpful if we hit it again. | ||
} | ||
// After the loop dbErr is the last connection error (if any). | ||
Uh oh!
There was an error while loading.Please reload this page.