- Notifications
You must be signed in to change notification settings - Fork948
chore: stop running postgres-only tests if DB is not set#18784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
spikecurtis merged 1 commit intomainfromspike/internal-695-disable-db-tests-without-postgresJul 8, 2025
Merged
chore: stop running postgres-only tests if DB is not set#18784
spikecurtis merged 1 commit intomainfromspike/internal-695-disable-db-tests-without-postgresJul 8, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| @@ -93,7 +93,7 @@ func initDefaultConnection(t TBSubset) error { | |||
| if !containsAnySubstring(errString, retryableErrSubstrings) { | |||
| break | |||
| } | |||
| t.Logf("failed to connect to postgres, retrying: %s", errString) | |||
| t.Logf("%sfailed to connect to postgres, retrying: %s", time.Now().Format(time.StampMilli), errString) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
added this because it looks like we only retried 3 times, even though we're supposed to wait 10 seconds. Timestamp information will be helpful if we hit it again.
hugodutka approved these changesJul 8, 2025
bf0271f intomain 41 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Merge activity
|
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixescoder/internal#695
PostgreSQL tests are getting run in a non-postgres CI job because the tests don't get skipped if the
DB=env is unset. This PR adds a skip for them.They are flaking in the
test-go-raceCI job. They run fine in thetest-go-race-pgjob, which pre-creates the postgres server, so the flakiness is almost certainly related to spinning up the database server.