NotificationsYou must be signed in to change notification settings
Fork1k
Star11.1k

fix: handle paths with spaces in Match exec clause of SSH config (cherry-pick #18266)#18778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

stirby merged 1 commit intorelease/2.23fromcherry-pick-164d37-release/2.23

Jul 8, 2025

Merged

fix: handle paths with spaces in Match exec clause of SSH config (cherry-pick #18266)#18778

stirby merged 1 commit intorelease/2.23fromcherry-pick-164d37-release/2.23

Jul 8, 2025

Conversation

Copy link

gcp-cherry-pick-botbot commentedJul 7, 2025

Cherry-picked fix: handle paths with spaces in Match exec clause of SSH config (#18266)

fixes#18199

Corrects handling of paths with spaces in theMatch !exec clause we
use to determine whether Coder Connect is running. This is handled
differently than the ProxyCommand, so we have a different escape
routine, which also varies by OS.

On Windows, we resort to a pretty gnarly hack, but it does work and I
feel the only other option would be to reduce functionality such that we
could not detect the Coder Connect state.

fix: handle paths with spaces in Match exec clause of SSH config (#18266

b01a101

)fixes#18199 Corrects handling of paths with spaces in the `Match !exec` clause weuse to determine whether Coder Connect is running. This is handleddifferently than the ProxyCommand, so we have a different escaperoutine, which also varies by OS.On Windows, we resort to a pretty gnarly hack, but it does work and Ifeel the only other option would be to reduce functionality such that wecould not detect the Coder Connect state.