- Notifications
You must be signed in to change notification settings - Fork1k
fix: handle paths with spaces in Match exec clause of SSH config (cherry-pick #18266)#18778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+161 −14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
)fixes#18199 Corrects handling of paths with spaces in the `Match !exec` clause weuse to determine whether Coder Connect is running. This is handleddifferently than the ProxyCommand, so we have a different escaperoutine, which also varies by OS.On Windows, we resort to a pretty gnarly hack, but it does work and Ifeel the only other option would be to reduce functionality such that wecould not detect the Coder Connect state.
spikecurtis approved these changesJul 8, 2025
049feec intorelease/2.23 31 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: handle paths with spaces in Match exec clause of SSH config (#18266)
fixes#18199
Corrects handling of paths with spaces in the
Match !execclause weuse to determine whether Coder Connect is running. This is handled
differently than the ProxyCommand, so we have a different escape
routine, which also varies by OS.
On Windows, we resort to a pretty gnarly hack, but it does work and I
feel the only other option would be to reduce functionality such that we
could not detect the Coder Connect state.