Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor: renameSettingsPages directory toUserSettingsPage#1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

AbhineetJain
Copy link
Contributor

This PR renames the directorySettingsPages toUserSettingsPage.

Subtasks

  • update the directory name
  • update the import statements

Fixes#1694

@AbhineetJainAbhineetJain requested a review froma team as acode ownerMay 27, 2022 21:57
@AbhineetJainAbhineetJain changed the titlerename settings pages directoryrenameSettingsPages directory toUserSettingsPageMay 27, 2022
@AbhineetJainAbhineetJainforce-pushed theabhineetjain/rename-settings-pages-directory branch fromd679362 tob1a0380CompareMay 27, 2022 22:23
@AbhineetJainAbhineetJain changed the titlerenameSettingsPages directory toUserSettingsPagerefactor: renameSettingsPages directory toUserSettingsPageMay 27, 2022
Copy link
Member

@Kira-PilotKira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nice!!!!

@AbhineetJainAbhineetJainforce-pushed theabhineetjain/rename-settings-pages-directory branch fromb1a0380 tof095622CompareMay 28, 2022 09:57
@AbhineetJainAbhineetJainforce-pushed theabhineetjain/rename-settings-pages-directory branch fromf095622 toe901e92CompareMay 31, 2022 14:08
@AbhineetJainAbhineetJainenabled auto-merge (squash)May 31, 2022 14:08
@AbhineetJainAbhineetJain merged commit9b19dc9 intomainMay 31, 2022
@AbhineetJainAbhineetJain deleted the abhineetjain/rename-settings-pages-directory branchMay 31, 2022 14:16
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

@greyscaledgreyscaledgreyscaled approved these changes

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chore: Confusing page/directory names
4 participants
@AbhineetJain@kylecarbs@greyscaled@Kira-Pilot
[8]ページ先頭
©2009-2025 Movatter.jp