- Notifications
You must be signed in to change notification settings - Fork947
chore: mark workspace apps and workspace agents as unaudited#18761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedJul 7, 2025
MemberAuthor
ethanndickson commentedJul 7, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Auditable4802e88 tobd16b9dComparec5131a3 tod14aa91Comparebd16b9d to273363fComparedeansheather approved these changesJul 7, 2025
d14aa91 toa4bb7c4Compare7c35e80 to8e0a43dCompare451bfd9 to59a7992Compare8e0a43d to3b8277bCompare59a7992 to13569cbCompare3b8277b to93a9073Compare13569cb toad9a966Compare93a9073 to23079d7Comparead9a966 to5153f7bCompare23079d7 to27eea0aCompare5153f7b to6c2f035Compare27eea0a to8a35e5fCompare6c2f035 tofab8dbdCompare8a35e5f toc58bc89Comparefab8dbd to245c72dComparec58bc89 to72a0299Compare245c72d to111ff29Compare72a0299 to44097edCompare111ff29 to6eb7cbeCompare44097ed to85c01aaCompare327e549 toe8b4e70Compare85c01aa to425c2dcCompare425c2dc to29e78d1Comparee8b4e70 to6b17aeeCompare29e78d1 to0d73833CompareMemberAuthor
ethanndickson commentedJul 15, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Merge activity
|
ef807e4 intomain 33 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The main goal of this PR is to remove Workspace Apps and Workspace Agents from the auto-generated audit log documentation, that incorrectly claims they are audited resources (no longer true with the addition of the connection log).
Though I believe we haven't touched any codepaths for returning audit logs, this PR also adds a test that ensures we continue to returnexisting connection, disconnect and open events correctly from the audit log API.