Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: make readinessProbe and livenessProbe initialDelaySeconds configurable#18756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
phorcys420 merged 2 commits intomainfromfeat/configurable-probe-delays
Jul 7, 2025

Conversation

blink-so[bot]
Copy link
Contributor

@blink-soblink-sobot commentedJul 4, 2025•
edited by phorcys420
Loading

MakesinitialDelaySeconds configurable for bothreadinessProbe andlivenessProbe in the Helm chart

Changes:

  • Addedcoder.readinessProbe.initialDelaySeconds andcoder.livenessProbe.initialDelaySeconds tovalues.yaml
  • Updated_coder.tpl template to use these configurable values
  • Defaults to 0 seconds to maintain existing behavior

Testing:

  • Verified template rendering with default values (0)
  • Verified template rendering with custom values (30, 60)
  • Both probes correctly use the configuredinitialDelaySeconds

…gurableAdds configurable initialDelaySeconds for readinessProbe and livenessProbein the Helm chart values.yaml and updates the _coder.tpl template to usethese values. Defaults to 0 seconds to maintain existing behavior.Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
@phorcys420phorcys420 self-requested a reviewJuly 4, 2025 16:21
Updates all helm chart test golden files to include the newinitialDelaySeconds: 0 configuration for readiness and liveness probes.Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
@phorcys420phorcys420enabled auto-merge (squash)July 6, 2025 09:21
@phorcys420phorcys420 merged commit6580971 intomainJul 7, 2025
38 checks passed
@phorcys420phorcys420 deleted the feat/configurable-probe-delays branchJuly 7, 2025 07:37
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 7, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ericpaulsenericpaulsenericpaulsen approved these changes

@phorcys420phorcys420Awaiting requested review from phorcys420

@jatcod3rjatcod3rAwaiting requested review from jatcod3r

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ericpaulsen@phorcys420
[8]ページ先頭
©2009-2025 Movatter.jp