- Notifications
You must be signed in to change notification settings - Fork1k
refactor: organize OAuth2 provider tests into dedicated packages#18747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
ThomasK33 merged 1 commit intomainfromthomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_packageJul 3, 2025
Merged
refactor: organize OAuth2 provider tests into dedicated packages#18747
ThomasK33 merged 1 commit intomainfromthomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_packageJul 3, 2025
+1,334 −413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedJul 3, 2025
This was referencedJul 3, 2025
MemberAuthor
ThomasK33 commentedJul 3, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
15cf36d to18ac26bCompare74ada5e to94f8522Comparejohnstcn approved these changesJul 3, 2025
94f8522 toc160ba6Compare18ac26b to8d14c45Comparec160ba6 to912fd87Compare8d14c45 toa97c96aCompare912fd87 toa2737b7Comparea97c96a toc261955Comparea2737b7 to865dc56Comparec261955 to2822d49Compare865dc56 to1f89b53Compare2822d49 tob6bbf89Comparedb0f2a0 toa586976Compareb6bbf89 to572628eCompare572628e to7af15dfCompare- Create oauth2provider/metadata_test.go with OAuth2 metadata endpoint tests- Create oauth2provider/validation_test.go with comprehensive client validation tests- Create oauth2provider/provider_test.go with provider app and registration tests- Remove duplicated tests from coderd/oauth2_test.go, keep integration tests- Fix lint issues in oauth2providertest package naming- Improve test organization with unit tests separated from integration tests- Maintain 100% test coverage while enabling faster test executionChange-Id: I99aac9f53df95eed3135d895781831a4a2749f6aSigned-off-by: Thomas Kosiewski <tk@coder.com>
7af15df to860ba25Compare4607e51 intomain 30 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Merge activity
|
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OAuth2 Provider Code Reorganization
This PR reorganizes the OAuth2 provider code to improve separation of concerns and maintainability. The changes include:
coderd/oauth2_test.gotooauth2provider/provider_test.gooauth2provider/validation_test.goOAuth2ProviderAppSecrettoAppSecretfor better naming consistencyoauth2_test.goto focus on core functionalityThe PR maintains all existing test coverage while organizing the code more logically, making it easier to understand and maintain the OAuth2 provider implementation. This reorganization will help with future enhancements to the OAuth2 provider functionality.