Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor: organize OAuth2 provider tests into dedicated packages#18747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@ThomasK33
Copy link
Member

OAuth2 Provider Code Reorganization

This PR reorganizes the OAuth2 provider code to improve separation of concerns and maintainability. The changes include:

  1. Migrating OAuth2 provider app validation tests fromcoderd/oauth2_test.go tooauth2provider/provider_test.go
  2. Moving OAuth2 client registration validation tests tooauth2provider/validation_test.go
  3. Adding new comprehensive test files for metadata and validation edge cases
  4. RenamingOAuth2ProviderAppSecret toAppSecret for better naming consistency
  5. Simplifying the main integration test inoauth2_test.go to focus on core functionality

The PR maintains all existing test coverage while organizing the code more logically, making it easier to understand and maintain the OAuth2 provider implementation. This reorganization will help with future enhancements to the OAuth2 provider functionality.

@ThomasK33Graphite App
Copy link
MemberAuthor

ThomasK33 commentedJul 3, 2025•
edited
Loading

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ThomasK33ThomasK33 marked this pull request as ready for reviewJuly 3, 2025 15:01
@ThomasK33ThomasK33force-pushed thethomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_package branch from15cf36d to18ac26bCompareJuly 3, 2025 15:16
@ThomasK33ThomasK33force-pushed thethomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package branch from74ada5e to94f8522CompareJuly 3, 2025 15:16
@ThomasK33ThomasK33 changed the titlerefactor: move OAuth2 provider tests to dedicated packages for better organizationrefactor: organize OAuth2 provider tests into dedicated packagesJul 3, 2025
@ThomasK33ThomasK33force-pushed thethomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package branch from94f8522 toc160ba6CompareJuly 3, 2025 16:37
@ThomasK33ThomasK33force-pushed thethomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_package branch from18ac26b to8d14c45CompareJuly 3, 2025 16:37
@ThomasK33ThomasK33force-pushed thethomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package branch fromc160ba6 to912fd87CompareJuly 3, 2025 16:53
@ThomasK33ThomasK33force-pushed thethomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_package branch from8d14c45 toa97c96aCompareJuly 3, 2025 16:54
@ThomasK33ThomasK33force-pushed thethomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package branch from912fd87 toa2737b7CompareJuly 3, 2025 17:15
@ThomasK33ThomasK33force-pushed thethomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_package branch froma97c96a toc261955CompareJuly 3, 2025 17:15
@ThomasK33ThomasK33force-pushed thethomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package branch froma2737b7 to865dc56CompareJuly 3, 2025 17:29
@ThomasK33ThomasK33force-pushed thethomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_package branch fromc261955 to2822d49CompareJuly 3, 2025 17:29
@ThomasK33ThomasK33force-pushed thethomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package branch from865dc56 to1f89b53CompareJuly 3, 2025 17:45
@ThomasK33ThomasK33force-pushed thethomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_package branch from2822d49 tob6bbf89CompareJuly 3, 2025 17:45
@ThomasK33ThomasK33force-pushed thethomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package branch 2 times, most recently fromdb0f2a0 toa586976CompareJuly 3, 2025 18:10
@ThomasK33ThomasK33force-pushed thethomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_package branch fromb6bbf89 to572628eCompareJuly 3, 2025 18:10
@ThomasK33ThomasK33 changed the base branch fromthomask33/07-03-refactor_oauth2_restructure_oauth2_provider_into_modular_package tographite-base/18747July 3, 2025 18:24
@ThomasK33ThomasK33force-pushed thethomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_package branch from572628e to7af15dfCompareJuly 3, 2025 18:25
@graphite-appgraphite-appbot changed the base branch fromgraphite-base/18747 tomainJuly 3, 2025 18:25
- Create oauth2provider/metadata_test.go with OAuth2 metadata endpoint tests- Create oauth2provider/validation_test.go with comprehensive client validation tests- Create oauth2provider/provider_test.go with provider app and registration tests- Remove duplicated tests from coderd/oauth2_test.go, keep integration tests- Fix lint issues in oauth2providertest package naming- Improve test organization with unit tests separated from integration tests- Maintain 100% test coverage while enabling faster test executionChange-Id: I99aac9f53df95eed3135d895781831a4a2749f6aSigned-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33ThomasK33force-pushed thethomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_package branch from7af15df to860ba25CompareJuly 3, 2025 18:25
@ThomasK33ThomasK33 merged commit4607e51 intomainJul 3, 2025
30 checks passed
@ThomasK33Graphite App
Copy link
MemberAuthor

Merge activity

@ThomasK33ThomasK33 deleted the thomask33/07-03-refactor_oauth2_migrate_test_files_to_oauth2provider_package branchJuly 3, 2025 18:41
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 3, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@ThomasK33ThomasK33

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ThomasK33@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp