Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: implement tests for dynamic parameter component#18745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 4 commits intomainfromjaaydenh/Dynamic-parameter-component-tests
Jul 3, 2025

Conversation

jaaydenh
Copy link
Contributor

No description provided.

Emyrk reacted with heart emoji
@jaaydenhjaaydenh self-assigned thisJul 3, 2025
@jaaydenhjaaydenh changed the titlechore: Dynamic Paramater component testschore: dynamic Parameter component testsJul 3, 2025
@jaaydenhjaaydenh changed the titlechore: dynamic Parameter component testschore: implement tests for dynamic parameter componentJul 3, 2025
@jaaydenhjaaydenh requested a review fromaslilacJuly 3, 2025 15:46
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would prefer that rather than one big long set of constants at the top, they be defined inside thedescribe the parameter is used in. feels a little weird to have to scroll so far to get to the first actual test. but overall looks good.

@jaaydenh
Copy link
ContributorAuthor

@aslilac some of the parameter constants are shared but I can move the ones that are not shared closer to the actual test.

@jaaydenhjaaydenh merged commit90a875d intomainJul 3, 2025
28 checks passed
@jaaydenhjaaydenh deleted the jaaydenh/Dynamic-parameter-component-tests branchJuly 3, 2025 17:10
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 3, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@jaaydenhjaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jaaydenh@aslilac
[8]ページ先頭
©2009-2025 Movatter.jp