Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(examples/templates): adddocker-devcontainer template and rename envbuilder template#18741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 12 commits intomainfrommafredri/feat-example-devcontainer-template
Jul 3, 2025

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedJul 3, 2025•
edited
Loading

This change adds a newdocker-devcontainer template which allows you to provision a workspace running in Docker, that also creates workspaces via Docker running inside (DinD).

  • chore(examples/templates): renamedocker-devcontainer todocker-envbuilder
  • feat(examples/templates): adddocker-devcontainer example template

Since GitHub is not detecting the renames properly and creating a hard-to-parse diff, I suggest reviewing commit-by-commit.

---
display_name:Docker (Devcontainer)
description:Provisionenvbuilder containers as Coder workspaces
display_name:Docker-in-Docker Dev Containers
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Open to naming suggestions.

@mafredrimafredri marked this pull request as ready for reviewJuly 3, 2025 10:25
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work! Some suggestions below.

@mafredrimafredriforce-pushed themafredri/feat-example-devcontainer-template branch from6689bbd tob9a3b72CompareJuly 3, 2025 11:19
@mafredrimafredri merged commit7d412c2 intomainJul 3, 2025
31 checks passed
@mafredrimafredri deleted the mafredri/feat-example-devcontainer-template branchJuly 3, 2025 12:50
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 3, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@mtojekmtojekmtojek approved these changes

@DanielleMaywoodDanielleMaywoodDanielleMaywood approved these changes

@EdwardAngertEdwardAngertAwaiting requested review from EdwardAngert

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@mafredri@johnstcn@mtojek@DanielleMaywood
[8]ページ先頭
©2009-2025 Movatter.jp