Jul 3, 2025 · Jul 3, 2025 · Jul 3, 2025 · Jul 3, 2025
diff --git a/cli/ping.go b/cli/ping.go
 if s.Min == nil || r.LatencySeconds < s.Min.Seconds() {
 s.Min = ptr.Ref(time.Duration(r.LatencySeconds * float64(time.Second)))
 }
 if s.Max == nil || r.LatencySeconds > s.Min.Seconds() {
 if s.Max == nil || r.LatencySeconds > s.Max.Seconds() {
 s.Max = ptr.Ref(time.Duration(r.LatencySeconds * float64(time.Second)))
 }
 s.latencySum += r.LatencySeconds
diff --git a/cli/ping_internal_test.go b/cli/ping_internal_test.go
 },
 {
 Err:            "",
 LatencySeconds: 0.2,
 LatencySeconds: 0.3,
 },
 {
 Err:            "",
 LatencySeconds: 0.3,
 LatencySeconds: 0.2,
 },
 {
 Err:            "ping error",
Original file line number	Diff line number	Diff line change
Expand Up		@@ -53,7 +53,7 @@ func (s pingSummary) addResult(r ipnstate.PingResult) {
		if s.Min == nil \|\| r.LatencySeconds < s.Min.Seconds() {
		s.Min = ptr.Ref(time.Duration(r.LatencySeconds * float64(time.Second)))
		}
		if s.Max == nil \|\| r.LatencySeconds > s.Min.Seconds() {
		if s.Max == nil \|\| r.LatencySeconds > s.Max.Seconds() {
		s.Max = ptr.Ref(time.Duration(r.LatencySeconds * float64(time.Second)))
		}
		s.latencySum += r.LatencySeconds
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -21,11 +21,11 @@ func TestBuildSummary(t *testing.T) {
		},
		{
		Err: "",
		LatencySeconds: 0.2,
		LatencySeconds: 0.3,
		},
		{
		Err: "",
		LatencySeconds: 0.3,
		LatencySeconds: 0.2,
Comment on lines +24 to +28 Copy link MemberAuthor ethanndicksonJul 3, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This reordering is the regression test
		},
		{
		Err: "ping error",
Expand Down