Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add search to parameter dropdowns#18729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 27 commits intomainfromlilac/select-search
Jul 15, 2025
Merged

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedJul 2, 2025•
edited
Loading

@aslilacaslilac changed the titlefeat: search dynamic parameter dropdownsfeat: add search to parameter dropdownsJul 10, 2025
@aslilacaslilac requested a review fromParkreinerJuly 10, 2025 23:26
@aslilacaslilac marked this pull request as ready for reviewJuly 11, 2025 00:07
@aslilacaslilac requested a review fromjaaydenhJuly 11, 2025 00:07
@aslilacaslilac removed the request for review fromjaaydenhJuly 14, 2025 18:21
Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good overall! Just had a few suggestions

import{cn}from"utils/cn";

interfaceComboboxProps{
value:string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I know this was here originally, but I can't help but feel likeselectedValue would be more clear, especially to avoid ambiguity withinputValue

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I thinkvalue is well enough established as "the current value of the input". whatI would really like to change isinputValue ->searchValue.

@aslilacaslilac merged commit52c4b61 intomainJul 15, 2025
28 checks passed
@aslilacaslilac deleted the lilac/select-search branchJuly 15, 2025 17:23
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ParkreinerParkreinerParkreiner approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for searching in single select dropdown component used in DynamicParamters
2 participants
@aslilac@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp