Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat!: add ability to cancel pending workspace build#18713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kacpersaw merged 22 commits intomainfromkacpersaw/cancel-pending-provisioner-jobs
Jul 8, 2025
Merged
Changes from1 commit
Commits
Show all changes
22 commits
Select commitHold shift + click to select a range
ba41ae8
add support for canceling workspace builds with expect_state param (l…
kacpersawJul 1, 2025
c4ee5b6
Use single transaction for canceling workspace build
kacpersawJul 2, 2025
c49c33e
Fix lint problem in ut
kacpersawJul 2, 2025
ba1dbf3
add cancel confirmation dialog for workspace builds and add expect_st…
kacpersawJul 2, 2025
acffda6
Fix lint
kacpersawJul 2, 2025
b672d76
Merge branch 'main' into kacpersaw/cancel-pending-provisioner-jobs
kacpersawJul 2, 2025
86a34df
Apply review suggestions
kacpersawJul 3, 2025
42170ab
Fix unit test
kacpersawJul 3, 2025
5db9d71
Apply review suggestions
kacpersawJul 3, 2025
1ede20c
Fix typo
kacpersawJul 3, 2025
2597615
Regenerate api types
kacpersawJul 3, 2025
6c2d0cf
Fix typo
kacpersawJul 3, 2025
c800494
Merge branch 'main' into kacpersaw/cancel-pending-provisioner-jobs
kacpersawJul 3, 2025
c5cb203
Apply a new authorization check for GetProvisionerJobByIDForUpdate
kacpersawJul 6, 2025
1de84cc
Apply a new authorization check for GetProvisionerJobByIDForUpdate
kacpersawJul 6, 2025
17fb6a3
Apply FE review suggestions
kacpersawJul 6, 2025
1b7b614
Apply review suggestions
kacpersawJul 7, 2025
634f556
Refactor cancelWorkspaceBuild parameter handling
kacpersawJul 7, 2025
4deace0
Fix lint
kacpersawJul 7, 2025
43430fa
Update coderd/workspacebuilds.go
kacpersawJul 7, 2025
6272d93
Extract cancel confirm dialog to a separate component
kacpersawJul 7, 2025
4d4a01d
Merge branch 'main' into kacpersaw/cancel-pending-provisioner-jobs
kacpersawJul 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
Fix typo
  • Loading branch information
@kacpersaw
kacpersaw committedJul 3, 2025
commit6c2d0cfb32f72313542923f19b13afae31ee4b7f
2 changes: 1 addition & 1 deletionsite/src/api/api.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1277,7 +1277,7 @@ class ApiMethods {

cancelWorkspaceBuild = async (
workspaceBuildId: TypesGen.WorkspaceBuild["id"],
request?: TypesGen.CancelWorkspaceBuildRequest,
request?: TypesGen.CancelWorkspaceBuildParams,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Since the type has the "Params" sufix, I would name this variable asparams instead ofrequest.

): Promise<TypesGen.Response> => {
const params = request?.expect_status
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You can do:

constparams=newURLSearchParams(params)

? new URLSearchParams({ expect_status: request.expect_status }).toString()
Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp