Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add MCP HTTP server experiment and improve experiment middleware#18712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@ThomasK33
Copy link
Member

Add MCP HTTP Server Experiment

This PR adds a new experiment flagmcp-server-http to enable the MCP HTTP server functionality. The changes include:

  1. Added a new experiment constantExperimentMCPServerHTTP with the value "mcp-server-http"
  2. Added display name and documentation for the new experiment
  3. Improved the experiment middleware to:
    • Support requiring multiple experiments
    • Provide better error messages with experiment display names
    • Add a development mode bypass option
  4. Applied the new experiment requirement to the MCP HTTP endpoint
  5. Replaced the custom OAuth2 middleware with the standard experiment middleware

The PR also improves theEnabled() method on theExperiments type by usingslices.Contains() for better readability.

This was referencedJul 2, 2025
@ThomasK33Graphite App
Copy link
MemberAuthor

ThomasK33 commentedJul 2, 2025•
edited
Loading

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ThomasK33ThomasK33 marked this pull request as ready for reviewJuly 2, 2025 12:09
@ThomasK33ThomasK33force-pushed thethomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints branch from610c661 toeff63b0CompareJuly 2, 2025 12:25
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch 2 times, most recently from3b81925 to7c1857aCompareJuly 2, 2025 12:44
@ThomasK33ThomasK33force-pushed thethomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints branch 2 times, most recently fromf181adb tobe45ca1CompareJuly 2, 2025 13:58
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch 2 times, most recently from2406fe7 to10bed55CompareJuly 2, 2025 14:05
@ThomasK33ThomasK33force-pushed thethomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints branch 2 times, most recently from27e77d8 to4eab4beCompareJuly 2, 2025 14:13
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch from10bed55 to91acaecCompareJuly 2, 2025 14:13
@ThomasK33ThomasK33force-pushed thethomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints branch from4eab4be tod64fbf9CompareJuly 2, 2025 14:39
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch from91acaec to46dec9aCompareJuly 2, 2025 14:41
@ThomasK33ThomasK33force-pushed thethomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints branch fromd64fbf9 to6af7251CompareJuly 2, 2025 14:41
@ThomasK33ThomasK33force-pushed thethomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints branch fromdb01ace to84da6b4CompareJuly 2, 2025 16:35
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch from76e5caf to9d10302CompareJuly 2, 2025 16:47
@ThomasK33ThomasK33force-pushed thethomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints branch from84da6b4 tobce9b62CompareJuly 2, 2025 16:48
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch from9d10302 toffbe385CompareJuly 2, 2025 17:02
@ThomasK33ThomasK33force-pushed thethomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints branch frombce9b62 to317120dCompareJuly 2, 2025 17:02
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch fromffbe385 tob4ecd2dCompareJuly 2, 2025 17:17
@ThomasK33ThomasK33force-pushed thethomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints branch 2 times, most recently from420f6df to665993dCompareJuly 3, 2025 15:00
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch fromb4ecd2d to377a7e8CompareJuly 3, 2025 15:00
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch from377a7e8 tob20b977CompareJuly 3, 2025 16:35
@ThomasK33ThomasK33force-pushed thethomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints branch from665993d to5d752e3CompareJuly 3, 2025 16:36
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch fromb20b977 to15df5c5CompareJuly 3, 2025 16:52
@ThomasK33ThomasK33force-pushed thethomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints branch from5d752e3 toe8b598eCompareJuly 3, 2025 16:53
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch from15df5c5 to5a4fab9CompareJuly 3, 2025 17:14
@ThomasK33ThomasK33force-pushed thethomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints branch frome8b598e tod7cac75CompareJuly 3, 2025 17:14
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch 2 times, most recently fromcd0cf55 to9045b65CompareJuly 3, 2025 17:28
@ThomasK33ThomasK33force-pushed thethomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints branch fromd7cac75 tocb75f3aCompareJuly 3, 2025 17:28
@ThomasK33ThomasK33 changed the base branch fromthomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout tographite-base/18712July 3, 2025 17:44
@ThomasK33ThomasK33force-pushed thethomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints branch fromcb75f3a tof62413eCompareJuly 3, 2025 17:44
@graphite-appgraphite-appbot changed the base branch fromgraphite-base/18712 tomainJuly 3, 2025 17:45
- Add ExperimentMCPServerHTTP constant for controlled rollout- Refactor OAuth2 middleware into generic experiment middleware- Make experiment middleware variadic to support multiple experiments- Apply experiment gating to /api/experimental/mcp/http routes- Maintain development mode bypass for testing flexibility- Remove OAuth2-specific middleware in favor of reusable patternChange-Id: Ia5b3d0615f4a5a45e5a233b1ea92e8bdc0a5f17eSigned-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33ThomasK33force-pushed thethomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints branch fromf62413e to9965337CompareJuly 3, 2025 17:45
@ThomasK33ThomasK33 merged commit7fbb3ce intomainJul 3, 2025
56 of 60 checks passed
@ThomasK33Graphite App
Copy link
MemberAuthor

Merge activity

@ThomasK33ThomasK33 deleted the thomask33/07-02-feat_mcp_add_experiment_control_for_mcp_server_http_endpoints branchJuly 3, 2025 18:09
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 3, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@ThomasK33ThomasK33

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ThomasK33@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp