- Notifications
You must be signed in to change notification settings - Fork1k
fix(site): update vs code dev container button URLs#18696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
a09db50
to5885da1
CompareParkreiner commentedJul 2, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Going to submit a review in must a minute. I have an idea for a piece of feedback, but I need to dig through a few files first to make sure it makes sense |
Parkreiner left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry for the delay (got caught up with Registry issues), but yeah, I'm okay with these changes
I'm a little concerned about the how the data is getting passed along (both button types receive a bunch of data dependencies, only for both to serialize them as almost identical strings). I'm worried someone might forget to update both (especially sinceURLSearchParams
doesn't have a ton of type-safety), but my attempts at refactoring didn't really seem to make things that much better
I think I'd rather wait until we have more data to serialize before worrying about drift. Everything's contained in the same file right now, and the variants aren't exported, so this all seems fine
8b6d70b
intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This updates the Dev Container VS Code button to include
localWorkspaceFolder
andlocalConfigFile
that will be added incoder/vscode-coder#544.This change is backwards compatible as the new arguments will be ignored.
Refscoder/vscode-coder#544
Refs#16426