Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(site): update vs code dev container button URLs#18696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedJul 1, 2025
edited
Loading

This updates the Dev Container VS Code button to includelocalWorkspaceFolder andlocalConfigFile that will be added incoder/vscode-coder#544.

This change is backwards compatible as the new arguments will be ignored.

Refscoder/vscode-coder#544
Refs#16426

@mafredrimafredriforce-pushed themafredri/fix-open-vscode-devcontainers-properly branch froma09db50 to5885da1CompareJuly 1, 2025 16:41
@mafredrimafredri marked this pull request as ready for reviewJuly 2, 2025 09:52
@Parkreiner
Copy link
Member

Parkreiner commentedJul 2, 2025
edited
Loading

Going to submit a review in must a minute. I have an idea for a piece of feedback, but I need to dig through a few files first to make sure it makes sense

Copy link
Member

@ParkreinerParkreiner left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry for the delay (got caught up with Registry issues), but yeah, I'm okay with these changes

I'm a little concerned about the how the data is getting passed along (both button types receive a bunch of data dependencies, only for both to serialize them as almost identical strings). I'm worried someone might forget to update both (especially sinceURLSearchParams doesn't have a ton of type-safety), but my attempts at refactoring didn't really seem to make things that much better

I think I'd rather wait until we have more data to serialize before worrying about drift. Everything's contained in the same file right now, and the variants aren't exported, so this all seems fine

mafredri reacted with heart emoji
@mafredrimafredri merged commit8b6d70b intomainJul 3, 2025
34 checks passed
@mafredrimafredri deleted the mafredri/fix-open-vscode-devcontainers-properly branchJuly 3, 2025 12:03
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 3, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ParkreinerParkreinerParkreiner approved these changes

@DanielleMaywoodDanielleMaywoodDanielleMaywood approved these changes

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mafredri@Parkreiner@DanielleMaywood

[8]ページ先頭

©2009-2025 Movatter.jp