Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add OAuth2 provider functionality as an experiment#18692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ThomasK33
Copy link
Member

Add OAuth2 Provider Functionality as an Experiment

This PR adds a new experiment flagoauth2 that enables OAuth2 provider functionality in Coder. When enabled, this experiment allows Coder to act as an OAuth2 provider.

The changes include:

  • Added the newExperimentOAuth2 constant with appropriate documentation
  • Updated the OAuth2 provider middleware to check for the experiment flag
  • Modified the error message to indicate that the OAuth2 provider requires enabling the experiment
  • Added the new experiment to the known experiments list in the SDK

Previously, OAuth2 provider functionality was only available in development mode. With this change, it can be enabled in production environments by activating the experiment.

@ThomasK33Graphite App
Copy link
MemberAuthor

ThomasK33 commentedJul 1, 2025•
edited
Loading

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ThomasK33ThomasK33 marked this pull request as ready for reviewJuly 1, 2025 13:24
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration branch from3e540ef to0447dc7CompareJuly 1, 2025 13:44
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch from95ae97b to0ea8930CompareJuly 1, 2025 13:44
Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration branch from0447dc7 to674964bCompareJuly 1, 2025 16:50
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch from0ea8930 to86c43d9CompareJuly 1, 2025 16:50
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration branch from674964b tode6e6b1CompareJuly 1, 2025 16:56
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch from86c43d9 to35540eaCompareJuly 1, 2025 16:56
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration branch fromde6e6b1 todf6f22cCompareJuly 1, 2025 17:04
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch from35540ea toe1f119cCompareJuly 1, 2025 17:04
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration branch fromdf6f22c to60161d7CompareJuly 1, 2025 17:18
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch 2 times, most recently from6d2afc9 to5865fb5CompareJuly 1, 2025 19:54
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration branch 2 times, most recently from16a48ef to06236c5CompareJuly 1, 2025 20:14
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch fromeb2ed15 to13103fdCompareJuly 2, 2025 15:53
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration branch from8672a4b toe55d907CompareJuly 2, 2025 16:35
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch from13103fd to76e5cafCompareJuly 2, 2025 16:35
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration branch frome55d907 to6684a17CompareJuly 2, 2025 16:46
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch from76e5caf to9d10302CompareJuly 2, 2025 16:47
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration branch from6684a17 to02bb2faCompareJuly 2, 2025 17:01
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch from9d10302 toffbe385CompareJuly 2, 2025 17:02
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration branch from02bb2fa to6dc9330CompareJuly 2, 2025 17:16
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch fromffbe385 tob4ecd2dCompareJuly 2, 2025 17:17
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration branch from6dc9330 tob8839e2CompareJuly 3, 2025 15:00
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch fromb4ecd2d to377a7e8CompareJuly 3, 2025 15:00
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration branch fromb8839e2 to7cc9428CompareJuly 3, 2025 16:35
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch from377a7e8 tob20b977CompareJuly 3, 2025 16:35
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration branch from7cc9428 to3c7a569CompareJuly 3, 2025 16:52
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch fromb20b977 to15df5c5CompareJuly 3, 2025 16:52
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration branch 2 times, most recently from74b951f to2e61d59CompareJuly 3, 2025 17:14
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch from15df5c5 to5a4fab9CompareJuly 3, 2025 17:14
@ThomasK33ThomasK33 changed the base branch fromthomask33/06-30-feat_mcp_implement_mcp_http_server_with_toolsdk_integration tographite-base/18692July 3, 2025 17:27
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch from5a4fab9 tocd0cf55CompareJuly 3, 2025 17:27
@graphite-appgraphite-appbot changed the base branch fromgraphite-base/18692 tomainJuly 3, 2025 17:28
…rollout- Add ExperimentOAuth2 constant to enable OAuth2 via experiment flag- Replace dev-only middleware with experiment-based gating- Maintain backward compatibility with dev mode- Allow OAuth2 enablement in production environments via --experimental=oauth2Change-Id: I51e021a21ad385c133783d715e872fb4069f9e66Signed-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33ThomasK33force-pushed thethomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branch fromcd0cf55 to9045b65CompareJuly 3, 2025 17:28
@ThomasK33ThomasK33 merged commit1555154 intomainJul 3, 2025
33 of 35 checks passed
@ThomasK33Graphite App
Copy link
MemberAuthor

Merge activity

@ThomasK33ThomasK33 deleted the thomask33/07-01-feat_oauth2_replace_dev_flag_with_oauth2_experiment_for_controlled_rollout branchJuly 3, 2025 17:44
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 3, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali approved these changes

@johnstcnjohnstcnAwaiting requested review from johnstcn

@mafredrimafredriAwaiting requested review from mafredri

Assignees

@ThomasK33ThomasK33

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ThomasK33@matifali
[8]ページ先頭
©2009-2025 Movatter.jp