- Notifications
You must be signed in to change notification settings - Fork1k
fix: stop tearing down non-TTY processes on SSH session end#18673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks reasonable to me 👍
b7cb275 intomainUh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Post-merge 👍
/cherry-pick release/2.24 |
/cherry-pick release/2.23 |
/cherry-pick release/2.22 |
Uh oh!
There was an error while loading.Please reload this page.
(possibly temporary) fix for#18519
Matches OpenSSH for non-tty sessions, where we don't actively terminate the process.
Adds explicit tracking to the SSH server for these processes so that if we are shutting down we terminate them: this ensures that we can shut down quickly to allow shutdown scripts to run. It also ensures our tests don't leak system resources.