- Notifications
You must be signed in to change notification settings - Fork928
chore: remove react imports#1867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -114,6 +114,9 @@ rules: | |||
| react/jsx-curly-brace-presence: | |||
| - error | |||
| - children: ignore | |||
| # https://reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html#eslint | |||
| react/jsx-uses-react: "off" | |||
| react/react-in-jsx-scope: "off" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Turning off these ESLint rules (as suggested by React) so we don't hear it complain.
| @@ -5,7 +5,7 @@ | |||
| "forceConsistentCasingInFileNames": true, | |||
| "incremental": true, | |||
| "isolatedModules": true, | |||
| "jsx": "react", | |||
| "jsx": "react-jsx", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This just informs React that we're using the new transform.
resolves#1856
Weno longer need to import React when using JSX.
This is a big change so definitely let me know if you have concerns.
I will comment below on any functional changes to assist in review.