Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: remove unique constraint on OAuth2 provider app names#18669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@ThomasK33
Copy link
Member

@ThomasK33ThomasK33 commentedJun 30, 2025•
edited
Loading

Remove unique constraint on OAuth2 provider app names

This PR removes the unique constraint on thename field in theoauth2_provider_apps table to comply with RFC 7591, which only requires unique client IDs, not unique client names.

Changes include:

  • Removing the unique constraint from the database schema
  • Adding migration files for both up and down migrations
  • Removing the name uniqueness check in the in-memory database implementation
  • Updating the unique constraint constants

Change-Id: Iae7a1a06546fbc8de541a52e291f8a4510d57e8a
Signed-off-by: Thomas Kosiewskitk@coder.com

@ThomasK33Graphite App
Copy link
MemberAuthor

ThomasK33 commentedJun 30, 2025•
edited
Loading

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ThomasK33ThomasK33 changed the titlefeat(oauth2): remove unique constraint on app names for RFC 7591 compliancefix: remove unique constraint on OAuth2 provider app namesJun 30, 2025
@ThomasK33ThomasK33 marked this pull request as ready for reviewJune 30, 2025 16:43
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from4efb07a to8a3f7a9CompareJune 30, 2025 16:45
@ThomasK33ThomasK33force-pushed thethomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from58b076d to88f01e4CompareJune 30, 2025 16:45
@mafredri
Copy link
Member

@ThomasK33 tests seem unhappy 😔

@ThomasK33Graphite App
Copy link
MemberAuthor

@ThomasK33 tests seem unhappy 😔

Yeah, I forgot to update them. On it.

@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from8a3f7a9 toe7d56c2CompareJune 30, 2025 17:08
@ThomasK33ThomasK33force-pushed thethomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from88f01e4 to0d042a4CompareJune 30, 2025 17:56
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch frome7d56c2 to10701daCompareJune 30, 2025 17:56
@ThomasK33ThomasK33force-pushed thethomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from0d042a4 tof4614fdCompareJuly 1, 2025 09:15
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch 2 times, most recently froma2607a8 to990f706CompareJuly 1, 2025 09:27
@ThomasK33ThomasK33force-pushed thethomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch fromf4614fd to5943be1CompareJuly 1, 2025 09:27
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from990f706 to95c0496CompareJuly 1, 2025 13:23
@ThomasK33ThomasK33force-pushed thethomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from5943be1 to2e85437CompareJuly 1, 2025 13:23
@ThomasK33ThomasK33force-pushed thethomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from2e85437 toaa379a5CompareJuly 1, 2025 13:42
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch fromf8aa2de to9851f81CompareJuly 2, 2025 13:58
@ThomasK33ThomasK33force-pushed thethomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch fromb7601e7 toce40271CompareJuly 2, 2025 14:06
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from9851f81 to43ac8a0CompareJuly 2, 2025 14:06
@ThomasK33ThomasK33force-pushed thethomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch fromce40271 to4095815CompareJuly 2, 2025 15:51
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from43ac8a0 to57a9498CompareJuly 2, 2025 15:52
@ThomasK33ThomasK33force-pushed thethomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from4095815 todf954c4CompareJuly 2, 2025 16:35
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from57a9498 to398eceaCompareJuly 2, 2025 16:35
@ThomasK33ThomasK33force-pushed thethomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch fromdf954c4 to2168bf9CompareJuly 2, 2025 16:45
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from398ecea to65635f0CompareJuly 2, 2025 16:46
@ThomasK33ThomasK33force-pushed thethomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from2168bf9 to9d2fe4dCompareJuly 2, 2025 17:00
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from65635f0 to27135bdCompareJuly 2, 2025 17:00
@ThomasK33ThomasK33force-pushed thethomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from9d2fe4d to95ea96cCompareJuly 2, 2025 17:15
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from27135bd tof4cdc20CompareJuly 2, 2025 17:16
@ThomasK33ThomasK33force-pushed thethomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from95ea96c toc667cbfCompareJuly 3, 2025 15:00
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch fromf4cdc20 to0ca3722CompareJuly 3, 2025 15:00
@ThomasK33ThomasK33force-pushed thethomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch 2 times, most recently fromdca4260 to3813249CompareJuly 3, 2025 16:34
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from0ca3722 to838d1deCompareJuly 3, 2025 16:34
@ThomasK33ThomasK33 changed the base branch fromthomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows tographite-base/18669July 3, 2025 16:51
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from838d1de to32959feCompareJuly 3, 2025 16:51
@graphite-appgraphite-appbot changed the base branch fromgraphite-base/18669 tomainJuly 3, 2025 16:52
…lianceChange-Id: Iae7a1a06546fbc8de541a52e291f8a4510d57e8aSigned-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33ThomasK33force-pushed thethomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from32959fe to6634f47CompareJuly 3, 2025 16:52
@ThomasK33ThomasK33 merged commit60b08f0 intomainJul 3, 2025
30 checks passed
@ThomasK33Graphite App
Copy link
MemberAuthor

Merge activity

@ThomasK33ThomasK33 deleted the thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branchJuly 3, 2025 17:13
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 3, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@mafredrimafredriAwaiting requested review from mafredri

Assignees

@ThomasK33ThomasK33

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ThomasK33@mafredri@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp