Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(agent/agentcontainers): always derive devcontainer name from workspace folder#18666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedJun 30, 2025
edited
Loading

Using the following Terraform I ran into an issue where devcontainers were named the same. The current strategy for naming devcontainers is overly complex and this change simplifies it by removing one source for them.

While at it, sort order of devcontainers is also made stable by sorting on devcontainer folder rather than name. The previous sorting resulted in devcontainers jumping around in the UI if their name changed.

resource"coder_devcontainer""repositories" {for_each=local.repositoriesagent_id=coder_agent.dev.idworkspace_folder="/home/coder/${module.git-clone[each.key].folder_name}"}

And this looks wrong in the UI:

image

And once the devcontainers come up, only one sub-agent can be created. The other will fail due to "name in use" because the implementation in the provisioner assumed this case is not possible.

image

@mafredrimafredri merged commit9ccaf86 intomainJun 30, 2025
33 checks passed
@mafredrimafredri deleted the mafredri/fix-agen-agentcontainers-name-devcontainers-via-folder branchJune 30, 2025 17:56
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 30, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@DanielleMaywoodDanielleMaywoodDanielleMaywood approved these changes

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mafredri@johnstcn@DanielleMaywood

[8]ページ先頭

©2009-2025 Movatter.jp