Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: use default preset when creating a workspace for task#18623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 2 commits intomainfrombq/fix-prebuild-for-tasks
Jun 27, 2025

Conversation

@BrunoQuaresma
Copy link
Contributor

No description provided.

@dannykoppingdannykoppingforce-pushed thebq/fix-prebuild-for-tasks branch fromc943a05 to2ab771cCompareJune 27, 2025 09:06
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good but don't we need a test?

@BrunoQuaresma
Copy link
ContributorAuthor

BrunoQuaresma commentedJun 27, 2025•
edited
Loading

Looks good but don't we need a test?

It would be great, but in the way we have the fetch calls structured/abstracted right now, it makes testing this quite painful. Since this is going to be a BE endpoint any time soon, I would not invest time on refactoring to make it more testable.

Wdyt@code-asher ?

@BrunoQuaresmaBrunoQuaresma merged commit6d305df intomainJun 27, 2025
48 of 49 checks passed
@BrunoQuaresmaBrunoQuaresma deleted the bq/fix-prebuild-for-tasks branchJune 27, 2025 15:01
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 27, 2025
@BrunoQuaresma
Copy link
ContributorAuthor

It is merged, but I'm open to add tests in case we find out a good solution for it.

@dannykopping
Copy link
Contributor

Not even a storybook?

@BrunoQuaresma
Copy link
ContributorAuthor

Not even a storybook?

It already has a storybook 🤔

@dannykopping
Copy link
Contributor

For tasks?

@BrunoQuaresma
Copy link
ContributorAuthor

@dannykopping
Copy link
Contributor

@dannykopping yeap.624de63c6aacee003aa84340-vugffdpsdx.chromatic.com?path=/story/pages-taskspage--loading-ai-templates

I don't see any mention of presets in that test; am I missing something?

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@dannykoppingdannykoppingdannykopping left review comments

@code-ashercode-ashercode-asher approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BrunoQuaresma@dannykopping@code-asher
[8]ページ先頭
©2009-2025 Movatter.jp