Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add user roles to menu#1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Kira-Pilot merged 4 commits intomainfromadd-user-roles-to-menu/kira-pilot
May 27, 2022

Conversation

Kira-Pilot
Copy link
Member

Resolves#1524
Screen Shot 2022-05-27 at 2 33 54 PM

Should I be doing something with organization here? I was a bit confused by the comments in the ticket.

@Kira-PilotKira-Pilot requested a review froma team as acode ownerMay 27, 2022 18:38
@kylecarbs
Copy link
Member

This is a very pretty purple! 😍

Kira-Pilot reacted with hooray emoji

@greyscaledgreyscaled changed the titlechore: add user roles to menufeat: add user roles to menuMay 27, 2022
@greyscaled
Copy link
Contributor

greyscaled commentedMay 27, 2022•
edited
Loading

Heads up - I changed the PR title tofeat:. When you go to squash/merge, can you ensure that it saysfeat:!

I certainly wouldn't want this feature being deemed a chore!

The comment here explains chore a bit:

# Any code task that operates outside of CI, docs, or the product. Examples
# include configurations, linters etc.
-chore

But the simple way to think of it is:

  • does it change the product or is it visible at all to the user or system?
  • if yes, it's 100% not a chore
  • if no, it might be a chore, or refactor, or test or so on so forth

:D

kylecarbs and Kira-Pilot reacted with thumbs up emoji

Copy link
Contributor

@greyscaledgreyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice one!

@Kira-PilotKira-Pilot merged commit6052607 intomainMay 27, 2022
@Kira-PilotKira-Pilot deleted the add-user-roles-to-menu/kira-pilot branchMay 27, 2022 19:27
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
* view user roles in menuresolves#1524* fix stories* PR feedback
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

@greyscaledgreyscaledgreyscaled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

View User Role(s) in User Menu
3 participants
@Kira-Pilot@kylecarbs@greyscaled
[8]ページ先頭
©2009-2025 Movatter.jp