- Notifications
You must be signed in to change notification settings - Fork927
feat: graduate prebuilds to general availability#18607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM 🥇 just a small question
| featureEnabled:false, | ||
| experimentEnabled:false, | ||
| expectedEnabled:false, | ||
| name:"Feature disabled", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is this the case where there's no license, since prebuilds require a premium license? That's the only scenario where the feature can be disabled, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Correct
c6e0ba1 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This PR removes the prebuilds experiment and allows the use of prebuilds without opting into an experiment.