NotificationsYou must be signed in to change notification settings
Fork926
Star10.1k

feat(.devcontainer): install dotfiles if present#18606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mafredri merged 2 commits intomainfrommafredri/feat-devcontainer-install-dotfiles

Jun 26, 2025

Merged

feat(.devcontainer): install dotfiles if present#18606

mafredri merged 2 commits intomainfrommafredri/feat-devcontainer-install-dotfiles

Jun 26, 2025

Conversation

Copy link

Member

mafredri commentedJun 26, 2025•
edited
Loading

Not happy about mounting in the whole $HOME into the container (even if read-only), but it only exists as a proposal. Seedevcontainers/spec#132.

github-actionsbot assignedmafredri

Jun 26, 2025

mafredri changed the title~~feat(devcontainer): install dotfiles if present~~feat(.devcontainer): install dotfiles if present

Jun 26, 2025

mafredri requested review fromjohnstcn andDanielleMaywood

June 26, 2025 12:18

mafredri force-pushed themafredri/feat-devcontainer-install-dotfiles branch from21326b3 to5b06170Compare

June 26, 2025 12:18

feat(devcontainer): install dotfiles if present

1027a37

mafredri force-pushed themafredri/feat-devcontainer-install-dotfiles branch from5b06170 to1027a37Compare

June 26, 2025 12:19

mafredri marked this pull request as ready for review

June 26, 2025 12:19

DanielleMaywood approved these changes

Jun 26, 2025

View reviewed changes

johnstcn approved these changes

Jun 26, 2025

View reviewed changes

Copy link

Member

johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I guess this does sort of highlight the remaining dependencies on the parent workspace. I figure we'd need to have some way for the agent to automatically set these up.

Copy link

MemberAuthor

mafredri commentedJun 26, 2025

I guess this does sort of highlight the remaining dependencies on the parent workspace. I figure we'd need to have some way for the agent to automatically set these up.

Yes! This can definitely be improved. It'd be nice to setCODER_DOTFILES_URL as acontainerEnv, and if present, runcoder dotfiles in the sub agent (startup script?), for example.