Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(site): setserver.allowedHosts in storybook config to.coder#18598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ethanndickson wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromethan/allow-dot-coder-storybook

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedJun 26, 2025
edited
Loading

This lets you browse storybook using a Coder Desktop hostname (i.e.workspace.coder:6006). The default configuration (includinglocalhost) will still work.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@@ -116,7 +116,7 @@ export default defineConfig({
secure: process.env.NODE_ENV === "production",
},
},
allowedHosts: true,
Copy link
MemberAuthor

@ethanndicksonethanndicksonJun 26, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Setting this totrue opens developers up (as they run their dev server) toDNS rebinding attacks, as mentioned in the documentation:

    /**     * The hostnames that Vite is allowed to respond to.     * `localhost` and subdomains under `.localhost` and all IP addresses are allowed by default.     * When using HTTPS, this check is skipped.     *     * If a string starts with `.`, it will allow that hostname without the `.` and all subdomains under the hostname.     * For example, `.example.com` will allow `example.com`, `foo.example.com`, and `foo.bar.example.com`.     *     * If set to `true`, the server is allowed to respond to requests for any hosts.     * This is not recommended as it will be vulnerable to DNS rebinding attacks.     */    allowedHosts?: string[] | true;

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If there's any other domains you'd like to add, let me know.

@ethanndicksonethanndickson marked this pull request as ready for reviewJune 26, 2025 06:49
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@BrunoQuaresma

[8]ページ先頭

©2009-2025 Movatter.jp