- Notifications
You must be signed in to change notification settings - Fork928
refactor: move required external auth buttons to the submit side#18586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think it would make sense to make the new component have parity with the previous one (or make the previous one reusable) but it looks good to me otherwise.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me!
| @@ -303,7 +303,7 @@ const TaskForm: FC<TaskFormProps> = ({ templates }) => { | |||
| <Buttonsize="sm"type="submit"disabled={isMissingExternalAuth}> | |||
| <Spinner | |||
| loading={createTaskMutation.isPending||isLoadingExternalAuth} | |||
| loading={createTaskMutation.isPending||isPollingExternalAuth} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this one should becreateTaskMutation.isPending || isLoadingExternalAuth || isPollingExternalAuth so it spins while waiting for auth to load as well right? (or we could use!missedExternalAuth).
| </Button> | ||
| </TooltipTrigger> | ||
| <TooltipContent> | ||
| Retry connect to {auth.display_name} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think ~ing sounds more natural:Retry connecting to
Before:
After:
