- Notifications
You must be signed in to change notification settings - Fork1.1k
fix: hide the preset parameter visibility switch when it has no effect#18574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
5 commits Select commitHold shift + click to select a range
8b704c2 fix: hide the preset parameter visibility switch when it has no effect
SasSwartfb04067 apply the same fix to the experimental page
SasSwartdc3c497 fix default preset story
SasSwart6fdc046 feat: remove the beta badge for presets
SasSwartea01ac5 Update site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx
SasSwartFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
NextNext commit
fix: hide the preset parameter visibility switch when it has no effect
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit8b704c2b2b51f4ac1958b5aa38c689d3c5272cd7
There are no files selected for viewing
39 changes: 21 additions & 18 deletionssite/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -387,25 +387,28 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({ | ||
| selectedOption={presetOptions[selectedPresetIndex]} | ||
| /> | ||
| </Stack> | ||
| {/* Only show the preset parameter visibility toggle if preset parameters are actually being modified, otherwise it is ineffectual */} | ||
SasSwart marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| {presetParameterNames.length > 0 && ( | ||
| <div | ||
| css={{ | ||
| display: "flex", | ||
| alignItems: "center", | ||
| gap: "8px", | ||
| }} | ||
| > | ||
| <Switch | ||
| id="show-preset-parameters" | ||
| checked={showPresetParameters} | ||
| onCheckedChange={setShowPresetParameters} | ||
| /> | ||
| <label | ||
| htmlFor="show-preset-parameters" | ||
| css={styles.description} | ||
| > | ||
| Show preset parameters | ||
| </label> | ||
| </div> | ||
| )} | ||
| </Stack> | ||
| </Stack> | ||
| )} | ||
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.