- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: refactor TestServer_X11 to use inproc networking#18564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedJun 25, 2025
ContributorAuthor
spikecurtis commentedJun 25, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This was referencedJun 25, 2025
1e438a6 tob39371fCompareb60589d to212e2a5CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
212e2a5 toa272b09Compareb39371f to319c17dComparemafredri approved these changesJun 27, 2025
Uh oh!
There was an error while loading.Please reload this page.
319c17d to6dc4eabComparea272b09 toe2d3899Compare6dc4eab tobbc6b4cComparee2d3899 tof3ebe91Compare2665ffd to32cfa80Comparef3ebe91 to449c022Compare32cfa80 toabcf3dfCompare449c022 to702c154Compare702c154 to011e763Comparea5bfb20 intomain 30 checks passed
Uh oh!
There was an error while loading.Please reload this page.
ContributorAuthor
spikecurtis commentedJun 27, 2025
Merge activity
|
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading.Please reload this page.
relates to#18263
Refactors the x11Forwarder to accept a networking
interfacethat we can fake out for testing. This isolates the unit tests from other processes listening in the port range used by X11 forwarding. This will become extremely important in up-stack PRs where we listen on every port in the range and need to control which ports have conflicts.